* [PATCH 20/22] xen_backend: Convert sysbus init function to realize function
[not found] <20181119120820.29878-1-maozhongyi@cmss.chinamobile.com>
@ 2018-11-19 12:08 ` Mao Zhongyi
2018-11-19 12:27 ` [PATCH 00/22] QOM'ify SysBusDeviceClass->init Cornelia Huck
[not found] ` <20181119120820.29878-21-maozhongyi@cmss.chinamobile.com>
2 siblings, 0 replies; 3+ messages in thread
From: Mao Zhongyi @ 2018-11-19 12:08 UTC (permalink / raw)
To: qemu-devel
Cc: anthony.perard, xen-devel, sstabellini, Zhang Shengju,
Mao Zhongyi
Use DeviceClass rather than SysBusDeviceClass in
xen_sysdev_class_init().
Cc: sstabellini@kernel.org
Cc: anthony.perard@citrix.com
Cc: xen-devel@lists.xenproject.org
Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
---
hw/xen/xen_backend.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/hw/xen/xen_backend.c b/hw/xen/xen_backend.c
index 9a8e8771ec..73b0ed0169 100644
--- a/hw/xen/xen_backend.c
+++ b/hw/xen/xen_backend.c
@@ -809,9 +809,8 @@ static const TypeInfo xensysbus_info = {
}
};
-static int xen_sysdev_init(SysBusDevice *dev)
+static void xen_sysdev_realize(DeviceState *dev, Error **errp)
{
- return 0;
}
static Property xen_sysdev_properties[] = {
@@ -821,9 +820,8 @@ static Property xen_sysdev_properties[] = {
static void xen_sysdev_class_init(ObjectClass *klass, void *data)
{
DeviceClass *dc = DEVICE_CLASS(klass);
- SysBusDeviceClass *k = SYS_BUS_DEVICE_CLASS(klass);
- k->init = xen_sysdev_init;
+ dc->realize = xen_sysdev_realize;
dc->props = xen_sysdev_properties;
dc->bus_type = TYPE_XENSYSBUS;
}
--
2.17.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 00/22] QOM'ify SysBusDeviceClass->init
[not found] <20181119120820.29878-1-maozhongyi@cmss.chinamobile.com>
2018-11-19 12:08 ` [PATCH 20/22] xen_backend: Convert sysbus init function to realize function Mao Zhongyi
@ 2018-11-19 12:27 ` Cornelia Huck
[not found] ` <20181119120820.29878-21-maozhongyi@cmss.chinamobile.com>
2 siblings, 0 replies; 3+ messages in thread
From: Cornelia Huck @ 2018-11-19 12:27 UTC (permalink / raw)
To: Mao Zhongyi
Cc: peter.maydell, david, qemu-devel, alistair.francis, kraxel,
edgar.iglesias, gxt, sstabellini, qemu-block, mst, armbru,
borntraeger, marcel.apfelbaum, anthony.perard, marcandre.lureau,
rth, thuth, ehabkost, richard.henderson, chouteau, qemu-s390x,
qemu-arm, jan.kiszka, xen-devel, david, kwolf, f4bug, mreitz,
michael, qemu-ppc, pbonzini
On Mon, 19 Nov 2018 20:07:58 +0800
Mao Zhongyi <maozhongyi@cmss.chinamobile.com> wrote:
> The SysBusDeviceClass::init() interface is considered
> as a legacy interface and there are currently some
> efforts going on to get rid of it. Thus convert
> SysBusDeviceClass::init to DeviceClass::realize.
In case my comment to the s390 change comes off as negative: I like
getting rid of the legacy interface :)
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread