From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [PATCH] qemu/configure: fix CFLAGS handling for
	i386
Date: Sat, 31 Mar 2012 17:52:57 +0100
Message-ID: <CAFEAcA9HOS75B_SdocuWENaKtgghDVrXNAZDVTJJf7Vs_AB+1Q@mail.gmail.com>
References: <20120330152436.GA31016@aepfle.de>
	<4F772590.2000603@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Return-path: <qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org>
In-Reply-To: <4F772590.2000603@suse.de>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
To: =?UTF-8?Q?Andreas_F=C3=A4rber?= <afaerber@suse.de>
Cc: Olaf Hering <olaf@aepfle.de>, xen-devel@lists.xensource.com, Erik Blake <eblake@redhat.com>, qemu-devel@nongnu.org
List-Id: xen-devel@lists.xenproject.org

On 31 March 2012 16:41, Andreas F=C3=A4rber <afaerber@suse.de> wrote:
> This is the only usage of +=3D outside Makefile fragments, so I wonder if
> its use may have been by accident. Is it safe in a POSIX context?
> Or should we better use CFLAGS=3D"$CFLAGS -march=3D486"?
> For QEMU_CFLAGS we use the pattern QEMU_CFLAGS=3D"-options $QEMU_CFLAGS"
> to allow overriding options.

For that matter, should this be setting QEMU_CFLAGS instead of
CFLAGS? I have to say I'm not entirely sure what the difference
is...

-- PMM