From: Roy Franz <roy.franz@linaro.org>
To: Jan Beulich <JBeulich@suse.com>
Cc: keir <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
tim <tim@xen.org>, xen-devel <xen-devel@lists.xen.org>,
Stefano Stabellini <Stefano.Stabellini@citrix.com>,
Fu Wei <fu.wei@linaro.org>
Subject: Re: [PATCH V4 12/15] Add efi_arch_use_config_file() function to control use of config file
Date: Fri, 12 Sep 2014 09:30:10 -0700 [thread overview]
Message-ID: <CAFECyb81Wuw4GejJMeNoLBtPd+tPoYVud-2ip6oqwie0gDpTQA@mail.gmail.com> (raw)
In-Reply-To: <5412B9C20200007800034507@mail.emea.novell.com>
[-- Attachment #1.1: Type: text/plain, Size: 2635 bytes --]
On Fri, Sep 12, 2014 at 12:15 AM, Jan Beulich <JBeulich@suse.com> wrote:
> >>> On 12.09.14 at 01:54, <stefano.stabellini@eu.citrix.com> wrote:
> > On Thu, 11 Sep 2014, Jan Beulich wrote:
> >> >>> On 10.09.14 at 02:52, <roy.franz@linaro.org> wrote:
> >> > - cols = rows = depth = 0;
> >> > - if ( !base_video )
> >> > - {
> >> > - name.cs = get_value(&cfg, section.s, "video");
> >> > - if ( !name.cs )
> >> > - name.cs = get_value(&cfg, "global", "video");
> >> > - if ( name.cs && !strncmp(name.cs, "gfx-", 4) )
> >> > + cols = rows = depth = 0;
> >> > + if ( !base_video )
> >> > {
> >> > - cols = simple_strtoul(name.cs + 4, &name.cs, 10);
> >> > - if ( *name.cs == 'x' )
> >> > - rows = simple_strtoul(name.cs + 1, &name.cs, 10);
> >> > - if ( *name.cs == 'x' )
> >> > - depth = simple_strtoul(name.cs + 1, &name.cs, 10);
> >> > - if ( *name.cs )
> >> > - cols = rows = depth = 0;
> >> > + name.cs = get_value(&cfg, section.s, "video");
> >> > + if ( !name.cs )
> >> > + name.cs = get_value(&cfg, "global", "video");
> >> > + if ( name.cs && !strncmp(name.cs, "gfx-", 4) )
> >> > + {
> >> > + cols = simple_strtoul(name.cs + 4, &name.cs, 10);
> >> > + if ( *name.cs == 'x' )
> >> > + rows = simple_strtoul(name.cs + 1, &name.cs, 10);
> >> > + if ( *name.cs == 'x' )
> >> > + depth = simple_strtoul(name.cs + 1, &name.cs,
> 10);
> >> > + if ( *name.cs )
> >> > + cols = rows = depth = 0;
> >> > + }
> >>
> >> So how is this video mode selection being represented then without
> >> config file? Don't you need to at least add a command line option for
> >> that?
> >
> > The scenario without config file is the one where Xen is loaded by GRUB.
> > Do we actually need to pass a video mode option in that case?
> > Wouldn't GRUB take care of changing video mode itself to the value
> > specified by the user before booting Xen? Xen can query the current
> > video mode afterwards.
>
> Ah, right, that's a good point.
>
> Jan
>
> I think we can leave this to GRUB in this case. It seems to have the
capability to set
video modes use EFI calls so it should be able to take care of this as well
as the EFI boot
portion of XEN. One of the difficulties with arm64 development right now
is that most of it is being
done on platforms without video, so any video code is rarely used or
tested.
Roy
[-- Attachment #1.2: Type: text/html, Size: 4066 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2014-09-12 16:30 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 0:51 [PATCH V4 00/15] arm64 EFI stub Roy Franz
2014-09-10 0:51 ` [PATCH V4 01/15] move x86 EFI boot code to common/efi Roy Franz
2014-09-11 13:50 ` Jan Beulich
2014-09-11 17:16 ` Roy Franz
2014-09-12 6:55 ` Jan Beulich
2014-09-10 0:51 ` [PATCH V4 02/15] Move x86 specific funtions/variables to arch header Roy Franz
2014-09-11 14:03 ` Jan Beulich
2014-09-11 17:33 ` Roy Franz
2014-09-12 7:04 ` Jan Beulich
2014-09-12 9:43 ` Ian Campbell
2014-09-12 9:53 ` Jan Beulich
2014-09-12 9:58 ` Ian Campbell
2014-09-12 16:52 ` Roy Franz
2014-09-10 0:51 ` [PATCH V4 03/15] create arch functions to get and process EFI memory map Roy Franz
2014-09-11 14:11 ` Jan Beulich
2014-09-11 17:40 ` Roy Franz
2014-09-12 7:07 ` Jan Beulich
2014-09-12 9:45 ` Ian Campbell
2014-09-12 9:56 ` Jan Beulich
2014-09-12 10:23 ` Ian Campbell
2014-09-12 10:35 ` Jan Beulich
2014-09-12 17:01 ` Roy Franz
2014-09-10 0:51 ` [PATCH V4 04/15] Add architecture functions for pre/post ExitBootServices Roy Franz
2014-09-11 14:13 ` Jan Beulich
2014-09-11 17:44 ` Roy Franz
2014-09-12 7:08 ` Jan Beulich
2014-09-12 9:46 ` Ian Campbell
2014-09-12 9:58 ` Jan Beulich
2014-09-12 16:57 ` Roy Franz
2014-09-15 8:47 ` Jan Beulich
2014-09-10 0:51 ` [PATCH V4 05/15] Add efi_arch_cfg_file() to handle arch specific cfg file fields Roy Franz
2014-09-11 14:16 ` Jan Beulich
2014-09-11 18:11 ` Roy Franz
2014-09-12 7:10 ` Jan Beulich
2014-09-10 0:51 ` [PATCH V4 06/15] Add efi_arch_handle_cmdline() for processing commandline Roy Franz
2014-09-11 14:22 ` Jan Beulich
2014-09-11 18:24 ` Roy Franz
2014-09-10 0:51 ` [PATCH V4 07/15] Move x86 specific video and disk probing code Roy Franz
2014-09-11 14:26 ` Jan Beulich
2014-09-11 18:30 ` Roy Franz
2014-09-12 7:12 ` Jan Beulich
2014-09-10 0:51 ` [PATCH V4 08/15] Add efi_arch_memory() for arch specific memory setup Roy Franz
2014-09-11 14:27 ` Jan Beulich
2014-09-10 0:51 ` [PATCH V4 09/15] Add arch specific module handling to read_file() Roy Franz
2014-09-11 14:40 ` Jan Beulich
2014-09-10 0:52 ` [PATCH V4 10/15] Add SMBIOS and runtime services setup arch functions Roy Franz
2014-09-11 14:44 ` Jan Beulich
2014-09-11 22:03 ` Roy Franz
2014-09-11 23:41 ` Stefano Stabellini
2014-09-12 7:14 ` Jan Beulich
2014-09-12 16:24 ` Roy Franz
2014-09-10 0:52 ` [PATCH V4 11/15] Add several misc. arch functions for EFI boot code Roy Franz
2014-09-11 14:45 ` Jan Beulich
2014-09-10 0:52 ` [PATCH V4 12/15] Add efi_arch_use_config_file() function to control use of config file Roy Franz
2014-09-11 14:49 ` Jan Beulich
2014-09-11 23:54 ` Stefano Stabellini
2014-09-12 7:15 ` Jan Beulich
2014-09-12 16:30 ` Roy Franz [this message]
2014-09-10 0:52 ` [PATCH V4 13/15] add arm64 cache flushing code from linux v3.16 Roy Franz
2014-09-10 0:52 ` [PATCH V4 14/15] Update libfdt to v1.4.0 Roy Franz
2014-09-10 0:52 ` [PATCH V4 15/15] Add ARM EFI boot support Roy Franz
2014-09-11 14:53 ` Jan Beulich
2014-09-11 22:26 ` Roy Franz
2014-09-12 7:17 ` Jan Beulich
2014-09-12 0:49 ` Stefano Stabellini
2014-09-12 3:21 ` Roy Franz
2014-09-12 17:41 ` Stefano Stabellini
2014-09-12 17:50 ` Roy Franz
2014-09-12 17:55 ` Stefano Stabellini
2014-09-22 11:13 ` Ian Campbell
2014-09-23 12:39 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFECyb81Wuw4GejJMeNoLBtPd+tPoYVud-2ip6oqwie0gDpTQA@mail.gmail.com \
--to=roy.franz@linaro.org \
--cc=JBeulich@suse.com \
--cc=Stefano.Stabellini@citrix.com \
--cc=fu.wei@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=keir@xen.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).