From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roy Franz Subject: Re: [PATCH V4 12/15] Add efi_arch_use_config_file() function to control use of config file Date: Fri, 12 Sep 2014 09:30:10 -0700 Message-ID: References: <1410310325-4509-1-git-send-email-roy.franz@linaro.org> <1410310325-4509-13-git-send-email-roy.franz@linaro.org> <5411D2B50200007800033FBE@mail.emea.novell.com> <5412B9C20200007800034507@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0968428297128236343==" Return-path: In-Reply-To: <5412B9C20200007800034507@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: keir , Ian Campbell , Stefano Stabellini , tim , xen-devel , Stefano Stabellini , Fu Wei List-Id: xen-devel@lists.xenproject.org --===============0968428297128236343== Content-Type: multipart/alternative; boundary=bcaec52d57cf7eab1b0502e0cc4b --bcaec52d57cf7eab1b0502e0cc4b Content-Type: text/plain; charset=UTF-8 On Fri, Sep 12, 2014 at 12:15 AM, Jan Beulich wrote: > >>> On 12.09.14 at 01:54, wrote: > > On Thu, 11 Sep 2014, Jan Beulich wrote: > >> >>> On 10.09.14 at 02:52, wrote: > >> > - cols = rows = depth = 0; > >> > - if ( !base_video ) > >> > - { > >> > - name.cs = get_value(&cfg, section.s, "video"); > >> > - if ( !name.cs ) > >> > - name.cs = get_value(&cfg, "global", "video"); > >> > - if ( name.cs && !strncmp(name.cs, "gfx-", 4) ) > >> > + cols = rows = depth = 0; > >> > + if ( !base_video ) > >> > { > >> > - cols = simple_strtoul(name.cs + 4, &name.cs, 10); > >> > - if ( *name.cs == 'x' ) > >> > - rows = simple_strtoul(name.cs + 1, &name.cs, 10); > >> > - if ( *name.cs == 'x' ) > >> > - depth = simple_strtoul(name.cs + 1, &name.cs, 10); > >> > - if ( *name.cs ) > >> > - cols = rows = depth = 0; > >> > + name.cs = get_value(&cfg, section.s, "video"); > >> > + if ( !name.cs ) > >> > + name.cs = get_value(&cfg, "global", "video"); > >> > + if ( name.cs && !strncmp(name.cs, "gfx-", 4) ) > >> > + { > >> > + cols = simple_strtoul(name.cs + 4, &name.cs, 10); > >> > + if ( *name.cs == 'x' ) > >> > + rows = simple_strtoul(name.cs + 1, &name.cs, 10); > >> > + if ( *name.cs == 'x' ) > >> > + depth = simple_strtoul(name.cs + 1, &name.cs, > 10); > >> > + if ( *name.cs ) > >> > + cols = rows = depth = 0; > >> > + } > >> > >> So how is this video mode selection being represented then without > >> config file? Don't you need to at least add a command line option for > >> that? > > > > The scenario without config file is the one where Xen is loaded by GRUB. > > Do we actually need to pass a video mode option in that case? > > Wouldn't GRUB take care of changing video mode itself to the value > > specified by the user before booting Xen? Xen can query the current > > video mode afterwards. > > Ah, right, that's a good point. > > Jan > > I think we can leave this to GRUB in this case. It seems to have the capability to set video modes use EFI calls so it should be able to take care of this as well as the EFI boot portion of XEN. One of the difficulties with arm64 development right now is that most of it is being done on platforms without video, so any video code is rarely used or tested. Roy --bcaec52d57cf7eab1b0502e0cc4b Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On F= ri, Sep 12, 2014 at 12:15 AM, Jan Beulich <JBeulich@suse.com> wrote:
>>> On 12.09.14 at 01:54, <stefano.stabellini@eu.citrix.com> wrote:
> On Thu, 11 Sep 2014, Jan Beulich wrote:
>> >>> On 10.09.14 at 02:52, <roy.franz@linaro.org> wrote:
>> > -=C2=A0 =C2=A0 cols =3D rows =3D depth =3D 0;
>> > -=C2=A0 =C2=A0 if ( !base_video )
>> > -=C2=A0 =C2=A0 {
>> > -=C2=A0 =C2=A0 =C2=A0 =C2=A0 name.cs =3D get_value(&cfg, = section.s, "video");
>> > -=C2=A0 =C2=A0 =C2=A0 =C2=A0 if ( !name.cs )
>> > -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 name.cs =3D get_va= lue(&cfg, "global", "video");
>> > -=C2=A0 =C2=A0 =C2=A0 =C2=A0 if ( name.cs && !strncmp= (name.cs, "gfx-", 4) )
>> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 cols =3D rows =3D depth =3D 0; >> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 if ( !base_video )
>> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 {
>> > -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 cols =3D simple_st= rtoul(name.cs + 4, &name.cs, 10);
>> > -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if ( *name.cs =3D= =3D 'x' )
>> > -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 rows= =3D simple_strtoul(name.cs + 1, &name.cs, 10);
>> > -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if ( *name.cs =3D= =3D 'x' )
>> > -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 dept= h =3D simple_strtoul(name.cs + 1, &name.cs, 10);
>> > -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if ( *name.cs ) >> > -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 cols= =3D rows =3D depth =3D 0;
>> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 name.cs =3D get_va= lue(&cfg, section.s, "video");
>> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if ( !name.cs ) >> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 name= .cs =3D get_value(&cfg, "global", "video");
>> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if ( name.cs &= & !strncmp(name.cs, "gfx-", 4) )
>> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 {
>> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 cols= =3D simple_strtoul(name.cs + 4, &name.cs, 10);
>> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (= *name.cs =3D=3D 'x' )
>> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 rows =3D simple_strtoul(name.cs + 1, &name.cs, 10);
>> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (= *name.cs =3D=3D 'x' )
>> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 depth =3D simple_strtoul(name.cs + 1, &name.cs, 10);
>> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (= *name.cs )
>> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 cols =3D rows =3D depth =3D 0;
>> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 }
>>
>> So how is this video mode selection being represented then without=
>> config file? Don't you need to at least add a command line opt= ion for
>> that?
>
> The scenario without config file is the one where Xen is loaded by GRU= B.
> Do we actually need to pass a video mode option in that case?
> Wouldn't GRUB take care of changing video mode itself to the value=
> specified by the user before booting Xen? Xen can query the current > video mode afterwards.

Ah, right, that's a good point.

Jan

I think we can leave this to GRUB in th= is case. =C2=A0It seems to have the capability to set
video modes= use EFI calls so it should be able to take care of this as well as the EFI= boot
portion of XEN. =C2=A0One of the difficulties with arm64 de= velopment right now is that most of it is being
done on platforms= without video, so any video code is rarely used or tested.=C2=A0

Roy


--bcaec52d57cf7eab1b0502e0cc4b-- --===============0968428297128236343== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============0968428297128236343==--