From mboxrd@z Thu Jan  1 00:00:00 1970
From: Roy Franz <roy.franz@linaro.org>
Subject: Re: [PATCH for-4.5 V6 00/14] arm64 EFI stub
Date: Wed, 24 Sep 2014 12:37:35 -0700
Message-ID: <CAFECyb9hw-9nzKa4idj2gxfKF-qGzLUXSjLMT7SrWv6-4ROaaA@mail.gmail.com>
References: <1411534992-27443-1-git-send-email-roy.franz@linaro.org>
	<5422A333020000780003816C@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5422A333020000780003816C@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: keir <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, tim <tim@xen.org>, xen-devel <xen-devel@lists.xen.org>, Stefano Stabellini <stefano.stabellini@citrix.com>, Fu Wei <fu.wei@linaro.org>
List-Id: xen-devel@lists.xenproject.org

On Wed, Sep 24, 2014 at 1:55 AM, Jan Beulich <JBeulich@suse.com> wrote:
>>>> On 24.09.14 at 07:02, <roy.franz@linaro.org> wrote:
>> Open feedback:
>> * moving extern declaration of efi_l4_pgtable.  I have left this x86 specific
>>   declaration in the x86 specific efi-boot.h file, as I don't see a clearly
>>   better place to put it.
>
> Since runtime.c (hopefully) doesn't include efi-boot.h, this is certainly
> not a viable option - files defining variables should include the headers
> declaring them.
>
> Jan
>

I'll move it and add a #ifdef