From: George Dunlap <George.Dunlap@eu.citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: ZhouPeng <zpengxen@gmail.com>,
"Xen-Devel (E-mail)" <xen-devel@lists.xensource.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
Subject: Re: [PATCH 2/3] tools:libxl: Add qxl vga interface support v2
Date: Wed, 16 Jan 2013 17:00:40 +0000 [thread overview]
Message-ID: <CAFLBxZYDs2P=YPobNaTrCSMe51eJphvbr2JBA_vCaUvbXUDCrA@mail.gmail.com> (raw)
In-Reply-To: <1353495722.13542.118.camel@zakaz.uk.xensource.com>
[-- Attachment #1.1: Type: text/plain, Size: 1147 bytes --]
On Wed, Nov 21, 2012 at 11:02 AM, Ian Campbell <Ian.Campbell@citrix.com>wrote:
> On Wed, 2012-11-21 at 03:27 +0000, ZhouPeng wrote:
> > I think, the key idea is just to support the default for qxl (128Mib)
> > in the discussion.
> > videoram is not designed for qxl video ram.
> > > If we reject values which are <128M, and clamp anything which is >128M
> > > to 128M then what is the point of the option?
> >
> > This piece of code doesn't mean to use videoram option to assign memory
> for qxl.
> > Because videoram option comes in Xen before qxl, it need to be consided
> here.
>
> You mean because video_memkb is used for VGA when QXL is disabled and
> QXL when it is? So the confusion here arises because this field is doing
> double duty.
>
> Perhaps it would be better to add a separate notion of qxl_memkb? The
> code in libxl__build_device_model_args_new and perhaps a handful of
> other places would need to account for either videoram or qxlram
> depending on which was enabled (you'd probably want a helper function
> for this).
>
> Is it possible to enable both VGA and QXL for a domain?
>
What's the status of this patch?
-George
[-- Attachment #1.2: Type: text/html, Size: 1625 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2013-01-16 17:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-05 11:22 [PATCH 2/3] tools:libxl: Add qxl vga interface support v2 ZhouPeng
2012-06-06 13:05 ` Ian Campbell
2012-06-07 3:19 ` ZhouPeng
2012-06-07 6:08 ` Ian Campbell
2012-06-07 7:49 ` ZhouPeng
2012-07-03 11:30 ` ZhouPeng
2012-07-03 14:24 ` Ian Campbell
2012-10-10 16:50 ` George Dunlap
2012-10-14 5:16 ` ZhouPeng
2012-10-18 10:19 ` ZhouPeng
2012-10-22 14:36 ` George Dunlap
2012-10-24 8:06 ` ZhouPeng
2012-10-24 13:25 ` George Dunlap
2012-10-30 7:45 ` ZhouPeng
2012-11-19 11:37 ` Ian Campbell
2012-11-21 3:27 ` ZhouPeng
2012-11-21 11:02 ` Ian Campbell
2013-01-16 17:00 ` George Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFLBxZYDs2P=YPobNaTrCSMe51eJphvbr2JBA_vCaUvbXUDCrA@mail.gmail.com' \
--to=george.dunlap@eu.citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
--cc=zpengxen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).