From: George Dunlap <dunlapg@umich.edu>
To: Wei Liu <wei.liu2@citrix.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
Stefano Stabellini <sstabellini@kernel.org>,
Ian Jackson <ian.jackson@eu.citrix.com>
Subject: Re: [PATCH] xl/libxl: add pvcalls support
Date: Tue, 13 Mar 2018 14:33:15 +0000 [thread overview]
Message-ID: <CAFLBxZYZHm1KBRCyusU-pPE7DPA6hTt_SvmhaQnQs-wDWU5e-A@mail.gmail.com> (raw)
In-Reply-To: <20180313141326.vfzb6z44xln5ccdj@citrix.com>
On Tue, Mar 13, 2018 at 2:13 PM, Wei Liu <wei.liu2@citrix.com> wrote:
> On Tue, Feb 27, 2018 at 01:28:08PM -0800, Stefano Stabellini wrote:
>> Add pvcalls support to libxl and xl. Create the appropriate pvcalls
>> entries in xenstore.
>>
>> Signed-off-by: Stefano Stabellini <stefano@aporeto.com>
>
> The code looks fine.
>
> I only want to have a second opinion on
>
>> @@ -829,6 +835,7 @@ libxl_domain_config = Struct("domain_config", [
>> ("vkbs", Array(libxl_device_vkb, "num_vkbs")),
>> ("vtpms", Array(libxl_device_vtpm, "num_vtpms")),
>> ("p9s", Array(libxl_device_p9, "num_p9s")),
>> + ("pvcallss", Array(libxl_device_pvcalls, "num_pvcallss")),
>
> this...
>
> I think the two s'es look a bit strange. But I don't have a better idea.
That does look a bit Gollum-like, my precioussss. Call individual
connections a "pvcalldev", and then have it "pvcalldevs" and
"num_pvcalldevs"?
Alternately, only allow a single pvcall connection?
-George
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-03-13 14:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 21:28 [PATCH] xl/libxl: add pvcalls support Stefano Stabellini
2018-03-05 22:00 ` Stefano Stabellini
2018-03-11 20:49 ` Stefano Stabellini
2018-03-13 14:13 ` Wei Liu
2018-03-13 14:33 ` George Dunlap [this message]
2018-03-13 17:29 ` Stefano Stabellini
2018-03-28 20:40 ` Stefano Stabellini
2018-03-29 16:52 ` Ian Jackson
2018-03-29 22:05 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFLBxZYZHm1KBRCyusU-pPE7DPA6hTt_SvmhaQnQs-wDWU5e-A@mail.gmail.com \
--to=dunlapg@umich.edu \
--cc=ian.jackson@eu.citrix.com \
--cc=sstabellini@kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).