From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH v2 09/10] libxl: Fix libxl_set_memory_target return value Date: Wed, 6 Apr 2016 13:54:10 +0100 Message-ID: References: <1459943163-18697-1-git-send-email-paulinaszubarczyk@gmail.com> <1459943163-18697-10-git-send-email-paulinaszubarczyk@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1anmyL-0002Eq-3d for xen-devel@lists.xenproject.org; Wed, 06 Apr 2016 12:54:13 +0000 Received: by mail-oi0-f66.google.com with SMTP id q133so6803732oib.1 for ; Wed, 06 Apr 2016 05:54:11 -0700 (PDT) In-Reply-To: <1459943163-18697-10-git-send-email-paulinaszubarczyk@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Paulina Szubarczyk Cc: Wei Liu , Ian Campbell , Dario Faggioli , Ian Jackson , xen-devel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= List-Id: xen-devel@lists.xenproject.org T24gV2VkLCBBcHIgNiwgMjAxNiBhdCAxMjo0NiBQTSwgUGF1bGluYSBTenViYXJjenlrCjxwYXVs aW5hc3p1YmFyY3p5a0BnbWFpbC5jb20+IHdyb3RlOgo+IEZyb206IEdlb3JnZSBEdW5sYXAgPEdl b3JnZS5EdW5sYXBAZXUuY2l0cml4LmNvbT4KPgo+IGxpYnhsX3NldF9tZW1vcnlfdGFyZ2V0IHNl ZW1zIHRvIGhhdmUgdGhlIGZvbGxvd2luZyByZXR1cm4gdmFsdWVzOgo+Cj4gKiAxIG9uIGZhaWx1 cmUsIGlmIHRoZSBmYWlsdXJlIGhhcHBlbnMgYmVjYXVzZSBvZiBhIHhlbnN0b3JlIGVycm9yICpv cioKPiAqIGludmFsaWQgdGFyZ2V0Cj4KPiAqIC0xIGlmIHRoZSBzZXRtYXhtZW0gaHlwZXJjYWxs Cj4KPiAqIC1lcnJubyBpZiB0aGUgc2V0X3BvZF90YXJnZXQgaHlwZXJjYWxsIHRhcmdldCBmYWls cwo+Cj4gKiAwIG9uIHN1Y2Nlc3MKPgo+IE1ha2UgaXQgY29uc2lzdGVudGx5IHJldHVybiBFUlJP Ul9GQUlMIG9uIGZhaWx1cmUsIHVubGVzcyB0aGUKPiBwYXJhbWV0ZXJzIHdlcmUgaW52YWxpZCwg aW4gd2hpY2ggY2FzZSByZXR1cm4gRVJST1JfSU5WQUwuCj4KPiBJbiBhY2NvcmRhbmNlIHdpdGgg Q09ESU5HX1NZVExFOgo+Cj4gMS4gTGVhdmUgcmMgdW5pbml0aWFsaXplZCwgYW5kIHNldCB3aGVu IGFuIGVycm9yIGlzIGRldGVjdGVkCj4KPiAyLiBVc2UgJ3InIGZvciByZXR1cm4gdmFsdWVzIHRv IGZ1bmN0aW9ucyB3aG9zZSByZXR1cm4gdmFsdWVzIGFyZSBhCj4gZGlmZmVyZW50IGVycm9yIHNw YWNlIChsaWtlIHhjX2RvbWFpbl9zZXRtYXhtZW0gYW5kCj4geGNfZG9tYWluX3NldF9wb2RfdGFy Z2V0KQo+Cj4gLS0tCj4gQ2hhbmdlZCBzaW5jZSB2MToKPgo+IDMuIFVzZSAnbHJjJyBmb3IgcmV0 dXJuIHZhbHVlcyB0byBsb2NhbCBmdW5jdGlvbnMgbGlieGxfXyoKPiB3aGVyZSBhIGZhaWx1cmUg bWVhbnMgcmV0cnksIHJhdGhlciB0aGFuIGZhaWwgdGhlIHdob2xlIGZ1bmN0aW9uCj4gKGxpYnhs X19maWxsX2RvbTBfbWVtb3J5X2luZm8pLCB0byByZWR1Y2UgdGhlIHJpc2sgb2YgdGhhdC4KPgo+ IFNpZ25lZC1vZmYtYnk6IEdlb3JnZSBEdW5sYXAgPEdlb3JnZS5EdW5sYXBAZXUuY2l0cml4LmNv bT4KPiBTaWduZWQtb2ZmLWJ5OiBQYXVsaW5hIFN6dWJhcmN6eWsgPHBhdWxpbmFzenViYXJjenlr QGdtYWlsLmNvbT4KCkZZSSBldmVyeXRoaW5nIGFmdGVyIHRoZSAiLS0tIiB3aWxsIGJlIGRpc2Nh cmRlZCBvbiBjb21taXQ7IHNvIHlvdQpuZWVkIGFsbCB0aGUgdGFncyAoc2lnbmVkLW9mZi1ieSwg YWNrZWQtYnksICZjKSB0byBiZSBiZWZvcmUgdGhhdC4KCiAtR2VvcmdlCgo+IC0tLQo+ICB0b29s cy9saWJ4bC9saWJ4bC5jIHwgMjggKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLQo+ICAxIGZp bGUgY2hhbmdlZCwgMTggaW5zZXJ0aW9ucygrKSwgMTAgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0t Z2l0IGEvdG9vbHMvbGlieGwvbGlieGwuYyBiL3Rvb2xzL2xpYnhsL2xpYnhsLmMKPiBpbmRleCA3 NWYwMGJlLi4wNTczNjZlIDEwMDY0NAo+IC0tLSBhL3Rvb2xzL2xpYnhsL2xpYnhsLmMKPiArKysg Yi90b29scy9saWJ4bC9saWJ4bC5jCj4gQEAgLTQ4MjQsNyArNDgyNCw3IEBAIGludCBsaWJ4bF9z ZXRfbWVtb3J5X3RhcmdldChsaWJ4bF9jdHggKmN0eCwgdWludDMyX3QgZG9taWQsCj4gICAgICAg ICAgaW50MzJfdCB0YXJnZXRfbWVta2IsIGludCByZWxhdGl2ZSwgaW50IGVuZm9yY2UpCj4gIHsK PiAgICAgIEdDX0lOSVQoY3R4KTsKPiAtICAgIGludCByYyA9IDEsIGFib3J0X3RyYW5zYWN0aW9u ID0gMDsKPiArICAgIGludCByYywgciwgbHJjLCBhYm9ydF90cmFuc2FjdGlvbiA9IDA7Cj4gICAg ICB1aW50NjRfdCBtZW1vcnlrYjsKPiAgICAgIHVpbnQzMl90IHZpZGVvcmFtID0gMDsKPiAgICAg IHVpbnQzMl90IGN1cnJlbnRfdGFyZ2V0X21lbWtiID0gMCwgbmV3X3RhcmdldF9tZW1rYiA9IDA7 Cj4gQEAgLTQ4NTIsMTUgKzQ4NTIsMTUgQEAgcmV0cnlfdHJhbnNhY3Rpb246Cj4gICAgICBpZiAo IXRhcmdldCAmJiAhZG9taWQpIHsKPiAgICAgICAgICBpZiAoIXhzX3RyYW5zYWN0aW9uX2VuZChj dHgtPnhzaCwgdCwgMSkpCj4gICAgICAgICAgICAgIGdvdG8gb3V0X25vX3RyYW5zYWN0aW9uOwo+ IC0gICAgICAgIHJjID0gbGlieGxfX2ZpbGxfZG9tMF9tZW1vcnlfaW5mbyhnYywgJmN1cnJlbnRf dGFyZ2V0X21lbWtiLAo+ICsgICAgICAgIGxyYyA9IGxpYnhsX19maWxsX2RvbTBfbWVtb3J5X2lu Zm8oZ2MsICZjdXJyZW50X3RhcmdldF9tZW1rYiwKPiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgJmN1cnJlbnRfbWF4X21lbWtiKTsKPiAtICAgICAgICBpZiAocmMg PCAwKQo+IC0gICAgICAgICAgICBnb3RvIG91dF9ub190cmFuc2FjdGlvbjsKPiArICAgICAgICBp ZiAobHJjIDwgMCkgeyByYyA9IEVSUk9SX0ZBSUw7IGdvdG8gb3V0X25vX3RyYW5zYWN0aW9uOyB9 Cj4gICAgICAgICAgZ290byByZXRyeV90cmFuc2FjdGlvbjsKPiAgICAgIH0gZWxzZSBpZiAoIXRh cmdldCkgewo+ICAgICAgICAgIExPR0UoRVJST1IsICJjYW5ub3QgZ2V0IHRhcmdldCBtZW1vcnkg aW5mbyBmcm9tICVzL21lbW9yeS90YXJnZXQiLAo+ICAgICAgICAgICAgICAgZG9tcGF0aCk7Cj4g ICAgICAgICAgYWJvcnRfdHJhbnNhY3Rpb24gPSAxOwo+ICsgICAgICAgIHJjID0gRVJST1JfRkFJ TDsKPiAgICAgICAgICBnb3RvIG91dDsKPiAgICAgIH0gZWxzZSB7Cj4gICAgICAgICAgY3VycmVu dF90YXJnZXRfbWVta2IgPSBzdHJ0b3VsKHRhcmdldCwgJmVuZHB0ciwgMTApOwo+IEBAIC00ODY4 LDYgKzQ4NjgsNyBAQCByZXRyeV90cmFuc2FjdGlvbjoKPiAgICAgICAgICAgICAgTE9HRShFUlJP UiwgImludmFsaWQgbWVtb3J5IHRhcmdldCAlcyBmcm9tICVzL21lbW9yeS90YXJnZXRcbiIsCj4g ICAgICAgICAgICAgICAgICAgdGFyZ2V0LCBkb21wYXRoKTsKPiAgICAgICAgICAgICAgYWJvcnRf dHJhbnNhY3Rpb24gPSAxOwo+ICsgICAgICAgICAgICByYyA9IEVSUk9SX0ZBSUw7Cj4gICAgICAg ICAgICAgIGdvdG8gb3V0Owo+ICAgICAgICAgIH0KPiAgICAgIH0KPiBAQCAtNDg3Niw2ICs0ODc3 LDcgQEAgcmV0cnlfdHJhbnNhY3Rpb246Cj4gICAgICAgICAgTE9HRShFUlJPUiwgImNhbm5vdCBn ZXQgbWVtb3J5IGluZm8gZnJvbSAlcy9tZW1vcnkvc3RhdGljLW1heCIsCj4gICAgICAgICAgICAg ICBkb21wYXRoKTsKPiAgICAgICAgICBhYm9ydF90cmFuc2FjdGlvbiA9IDE7Cj4gKyAgICAgICAg cmMgPSBFUlJPUl9GQUlMOwo+ICAgICAgICAgIGdvdG8gb3V0Owo+ICAgICAgfQo+ICAgICAgbWVt b3J5a2IgPSBzdHJ0b3VsKG1lbW1heCwgJmVuZHB0ciwgMTApOwo+IEBAIC00ODgzLDYgKzQ4ODUs NyBAQCByZXRyeV90cmFuc2FjdGlvbjoKPiAgICAgICAgICBMT0dFKEVSUk9SLCAiaW52YWxpZCBt YXggbWVtb3J5ICVzIGZyb20gJXMvbWVtb3J5L3N0YXRpYy1tYXhcbiIsCj4gICAgICAgICAgICAg ICBtZW1tYXgsIGRvbXBhdGgpOwo+ICAgICAgICAgIGFib3J0X3RyYW5zYWN0aW9uID0gMTsKPiAr ICAgICAgICByYyA9IEVSUk9SX0ZBSUw7Cj4gICAgICAgICAgZ290byBvdXQ7Cj4gICAgICB9Cj4K PiBAQCAtNDkwMiw2ICs0OTA1LDcgQEAgcmV0cnlfdHJhbnNhY3Rpb246Cj4gICAgICAgICAgICAg ICJtZW1vcnlfZHluYW1pY19tYXggbXVzdCBiZSBsZXNzIHRoYW4gb3IgZXF1YWwgdG8iCj4gICAg ICAgICAgICAgICIgbWVtb3J5X3N0YXRpY19tYXhcbiIpOwo+ICAgICAgICAgIGFib3J0X3RyYW5z YWN0aW9uID0gMTsKPiArICAgICAgICByYyA9IEVSUk9SX0lOVkFMOwo+ICAgICAgICAgIGdvdG8g b3V0Owo+ICAgICAgfQo+Cj4gQEAgLTQ5MDksMzMgKzQ5MTMsMzYgQEAgcmV0cnlfdHJhbnNhY3Rp b246Cj4gICAgICAgICAgTE9HKEVSUk9SLCAibmV3IHRhcmdldCAlZCBmb3IgZG9tMCBpcyBiZWxv dyB0aGUgbWluaW11bSB0aHJlc2hvbGQiLAo+ICAgICAgICAgICAgICBuZXdfdGFyZ2V0X21lbWti KTsKPiAgICAgICAgICBhYm9ydF90cmFuc2FjdGlvbiA9IDE7Cj4gKyAgICAgICAgcmMgPSBFUlJP Ul9JTlZBTDsKPiAgICAgICAgICBnb3RvIG91dDsKPiAgICAgIH0KPgo+ICAgICAgaWYgKGVuZm9y Y2UpIHsKPiAgICAgICAgICBtZW1vcnlrYiA9IG5ld190YXJnZXRfbWVta2IgKyB2aWRlb3JhbTsK PiAtICAgICAgICByYyA9IHhjX2RvbWFpbl9zZXRtYXhtZW0oY3R4LT54Y2gsIGRvbWlkLCBtZW1v cnlrYiArCj4gKyAgICAgICAgciA9IHhjX2RvbWFpbl9zZXRtYXhtZW0oY3R4LT54Y2gsIGRvbWlk LCBtZW1vcnlrYiArCj4gICAgICAgICAgICAgICAgICBMSUJYTF9NQVhNRU1fQ09OU1RBTlQpOwo+ IC0gICAgICAgIGlmIChyYyAhPSAwKSB7Cj4gKyAgICAgICAgaWYgKHIgIT0gMCkgewo+ICAgICAg ICAgICAgICBMT0dFKEVSUk9SLAo+ICAgICAgICAgICAgICAgICAgICJ4Y19kb21haW5fc2V0bWF4 bWVtIGRvbWlkPSV1IG1lbWtiPSUiUFJJdTY0IiBmYWlsZWQgIiJyYz0lZFxuIiwKPiAgICAgICAg ICAgICAgICAgICBkb21pZCwKPiAgICAgICAgICAgICAgICAgICBtZW1vcnlrYiArIExJQlhMX01B WE1FTV9DT05TVEFOVCwKPiAtICAgICAgICAgICAgICAgICByYyk7Cj4gKyAgICAgICAgICAgICAg ICAgcik7Cj4gICAgICAgICAgICAgIGFib3J0X3RyYW5zYWN0aW9uID0gMTsKPiArICAgICAgICAg ICAgcmMgPSBFUlJPUl9GQUlMOwo+ICAgICAgICAgICAgICBnb3RvIG91dDsKPiAgICAgICAgICB9 Cj4gICAgICB9Cj4KPiAtICAgIHJjID0geGNfZG9tYWluX3NldF9wb2RfdGFyZ2V0KGN0eC0+eGNo LCBkb21pZCwKPiArICAgIHIgPSB4Y19kb21haW5fc2V0X3BvZF90YXJnZXQoY3R4LT54Y2gsIGRv bWlkLAo+ICAgICAgICAgICAgICAobmV3X3RhcmdldF9tZW1rYiArIExJQlhMX01BWE1FTV9DT05T VEFOVCkgLyA0LCBOVUxMLCBOVUxMLCBOVUxMKTsKPiAtICAgIGlmIChyYyAhPSAwKSB7Cj4gKyAg ICBpZiAociAhPSAwKSB7Cj4gICAgICAgICAgTE9HRShFUlJPUiwKPiAgICAgICAgICAgICAgICJ4 Y19kb21haW5fc2V0X3BvZF90YXJnZXQgZG9taWQ9JWQsIG1lbWtiPSVkICIiZmFpbGVkIHJjPSVk XG4iLAo+ICAgICAgICAgICAgICAgZG9taWQsCj4gICAgICAgICAgICAgICBuZXdfdGFyZ2V0X21l bWtiIC8gNCwKPiAtICAgICAgICAgICAgIHJjKTsKPiArICAgICAgICAgICAgIHIpOwo+ICAgICAg ICAgIGFib3J0X3RyYW5zYWN0aW9uID0gMTsKPiArICAgICAgICByYyA9IEVSUk9SX0ZBSUw7Cj4g ICAgICAgICAgZ290byBvdXQ7Cj4gICAgICB9Cj4KPiBAQCAtNDk0OSw2ICs0OTU2LDcgQEAgcmV0 cnlfdHJhbnNhY3Rpb246Cj4gICAgICAgICAgICAgICAgICAgICAgICIlIlBSSXUzMiwgbmV3X3Rh cmdldF9tZW1rYiAvIDEwMjQpOwo+ICAgICAgbGlieGxfZG9taW5mb19kaXNwb3NlKCZwdHIpOwo+ Cj4gKyAgICByYyA9IDA7Cj4gIG91dDoKPiAgICAgIGlmICgheHNfdHJhbnNhY3Rpb25fZW5kKGN0 eC0+eHNoLCB0LCBhYm9ydF90cmFuc2FjdGlvbikKPiAgICAgICAgICAmJiAhYWJvcnRfdHJhbnNh Y3Rpb24pCj4gLS0KPiAxLjkuMQo+Cj4KPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwo+IFhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKPiBYZW4tZGV2ZWxAbGlz dHMueGVuLm9yZwo+IGh0dHA6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlz dApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK