From: George Dunlap <dunlapg@umich.edu>
To: Alexandru Isaila <aisaila@bitdefender.com>
Cc: Tamas K Lengyel <tamas@tklengyel.com>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
Razvan Cojocaru <rcojocaru@bitdefender.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Xen-devel <xen-devel@lists.xen.org>,
Jan Beulich <jbeulich@suse.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH v2 1/4] asm-x86/monitor: Enable svm monitor events
Date: Fri, 9 Feb 2018 10:28:31 +0000 [thread overview]
Message-ID: <CAFLBxZbB65ALGcu1mZ2ajwZ3yXEcMf8hhKf3mwSVN0h_kesQQw@mail.gmail.com> (raw)
In-Reply-To: <1518103552-4836-2-git-send-email-aisaila@bitdefender.com>
On Thu, Feb 8, 2018 at 3:25 PM, Alexandru Isaila
<aisaila@bitdefender.com> wrote:
> This commit separates the svm caps from the vmx caps.
I can see how the patch relates to the description here, but it's not
immediately clear how it relates to the title.
A good "template" to start with for any commit message is:
1. What the current situation is
2. Why that's a problem
3. How this patch fixes it
The only time you should omit any of these is if it's completely obvious.
In this case, it looks like the answers would look like:
1. Only a subset of the monitor features are available on AMD, but all
capabilities are passed regardless of the processor architecture.
2. This means that the majority of functionality advertized in
'capabilities' is actually broken when running under AMD.
3. Separate out features which are implemented on both systems from
those implemented only on Intel, so that on AMD systems we only
advertize functionality that works.
Is that about right?
-George
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-02-09 10:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 15:25 [PATCH v2 0/4] hvm/svm: Enable vm events for SVM Alexandru Isaila
2018-02-08 15:25 ` [PATCH v2 1/4] asm-x86/monitor: Enable svm monitor events Alexandru Isaila
2018-02-08 18:00 ` Tamas K Lengyel
2018-02-09 10:28 ` George Dunlap [this message]
2018-02-09 10:54 ` George Dunlap
2018-02-09 16:21 ` Tamas K Lengyel
2018-02-21 11:50 ` George Dunlap
2018-02-10 16:30 ` Boris Ostrovsky
2018-02-10 19:51 ` Boris Ostrovsky
2018-02-08 15:25 ` [PATCH v2 2/4] hvm/svm: Enable Breakpoint events Alexandru Isaila
2018-02-08 18:03 ` Tamas K Lengyel
2018-02-09 10:31 ` George Dunlap
2018-02-10 16:31 ` Boris Ostrovsky
2018-02-08 15:25 ` [PATCH v2 3/4] hvm/svm: Enable MSR events Alexandru Isaila
2018-02-08 18:04 ` Tamas K Lengyel
2018-02-09 10:37 ` George Dunlap
2018-02-09 11:03 ` Alexandru Stefan ISAILA
2018-02-10 16:33 ` Boris Ostrovsky
2018-02-10 20:26 ` Boris Ostrovsky
2018-02-08 15:25 ` [PATCH v2 4/4] hvm/svm: Enable CR events Alexandru Isaila
2018-02-08 18:06 ` Tamas K Lengyel
2018-02-09 13:10 ` Alexandru Stefan ISAILA
2018-02-09 16:24 ` Tamas K Lengyel
2018-02-09 16:41 ` George Dunlap
2018-02-09 16:25 ` Tamas K Lengyel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFLBxZbB65ALGcu1mZ2ajwZ3yXEcMf8hhKf3mwSVN0h_kesQQw@mail.gmail.com \
--to=dunlapg@umich.edu \
--cc=aisaila@bitdefender.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jbeulich@suse.com \
--cc=rcojocaru@bitdefender.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=tamas@tklengyel.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).