From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH 4/5] Xen/MCE: Abort live migration when vMCE occur Date: Fri, 19 Oct 2012 17:51:40 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: "Liu, Jinsong" Cc: Christoph Egger , "xen-devel@lists.xensource.com" , "Keir (Xen.org)" , Ian Campbell , Ian Jackson , Jan Beulich List-Id: xen-devel@lists.xenproject.org On Wed, Oct 10, 2012 at 3:46 PM, Liu, Jinsong wrote: > Xen/MCE: Abort live migration when vMCE occur > > This patch monitor the critical area of live migration (from vMCE point of view, > the copypages stage of migration is the critical area while other areas are not). > > If a vMCE occur at the critical area of live migration, there is risk that error > data may be copied to the target. Currently we don't have convenient way to handle > this case, so for the sake of safe, we abort it and try migration later (at that > time broken page would not be mapped and copied to the target). > > Signed-off-by: Liu, Jinsong I'm not sure exactly what this patch is meant to do -- it won't actually stop the broken page from being read, and it won't stop the migration in the middle; instead it will finish copying the memory before deciding to quit. Wouldn't your patch 5 be sufficient to deal with this case? It seems like the broken page would get marked as such, and then get marked broken on the receiving side, wouldn't it? -George