Re: [PATCH v3 0/3] map grant refs at pfn = mfn

[Thomas Leonard <talex5@gmail.com>]

On 6 August 2014 16:59, Wei Liu <wei.liu2@citrix.com> wrote:
> Thomas, can you give this patch a quick try? I only compile test it
> because I don't have handy testing environment at the moment.
>
> Apply it to Dom0 kernel.
>
> ---8<---
> From b32aa53ba8b79f0006780549953510930513a3ac Mon Sep 17 00:00:00 2001
> From: Wei Liu <wei.liu2@citrix.com>
> Date: Wed, 6 Aug 2014 16:50:06 +0100
> Subject: [PATCH] xen-netback: don't stop kthreads until all in-flight packets
>  are processed
>
> Reference count the number of packets in host stack, so that we don't
> stop the deallocation thread too early. If not, we can end up with
> xenvif_free permanently waiting for deallocation thread to unmap grefs.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>

That stops the errors being printed, but I still have a domain I can't destroy:

$ xl list
Name                                        ID   Mem VCPUs      State   Time(s)
Domain-0                                     0   512     2     r-----      35.6
(null)                                       1     0     1     --ps-d       0.1

I do see this after a bit:

[  240.062339] INFO: task xenwatch:18 blocked for more than 120 seconds.
[  240.062404]       Not tainted 3.16.0-rc7-00004-g9d89db9 #1
[  240.062426] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs"
disables this message.

The load average is 1.

If I try to create the domain again, I get:

$ xl create -c network.xl
Parsing config from network.xl
libxl: error: libxl_device.c:934:device_backend_callback: unable to
add device with path /local/domain/0/backend/vif/4/0
libxl: error: libxl_create.c:1226:domcreate_attach_vtpms: unable to
add nic devices
libxl: error: libxl_device.c:934:device_backend_callback: unable to
remove device with path /local/domain/0/backend/vif/4/0
libxl: error: libxl.c:1457:devices_destroy_cb: libxl__devices_destroy
failed for 4


-- 
Dr Thomas Leonard        http://0install.net/
GPG: 9242 9807 C985 3C07 44A6  8B9A AE07 8280 59A5 3CC1
GPG: DA98 25AE CAD0 8975 7CDA  BD8E 0713 3F96 CA74 D8BA