From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oleksandr Tyshchenko Subject: Re: [PATCH] xen/arm: route irqs to cpu0 Date: Tue, 4 Feb 2014 18:56:48 +0200 Message-ID: References: <1390844023-23123-1-git-send-email-oleksandr.tyshchenko@globallogic.com> <52E69CBC.3090207@linaro.org> <52F11627.4020005@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <52F11627.4020005@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: George Dunlap , xen-devel@lists.xen.org, Ian Campbell , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org Thanks. I need this patch. On Tue, Feb 4, 2014 at 6:32 PM, Julien Grall wrote: > On 02/04/2014 04:20 PM, Stefano Stabellini wrote: >> gic_route_irq_to_guest routes all IRQs to >> cpumask_of(smp_processor_id()), but actually it always called on cpu0. >> To avoid confusion and possible issues in case someone modified the code >> and reassigned a particular irq to a cpu other than cpu0, hardcode >> cpumask_of(0). >> >> Signed-off-by: Stefano Stabellini > Acked-by: Julien Grall > >> >> diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c >> index e6257a7..8854800 100644 >> --- a/xen/arch/arm/gic.c >> +++ b/xen/arch/arm/gic.c >> @@ -776,8 +776,8 @@ int gic_route_irq_to_guest(struct domain *d, const struct dt_irq *irq, >> >> level = dt_irq_is_level_triggered(irq); >> >> - gic_set_irq_properties(irq->irq, level, cpumask_of(smp_processor_id()), >> - 0xa0); >> + /* TODO: handle routing irqs to cpus != cpu0 */ >> + gic_set_irq_properties(irq->irq, level, cpumask_of(0), 0xa0); >> >> retval = __setup_irq(desc, irq->irq, action); >> if (retval) { >> > > > -- > Julien Grall -- Name | Title GlobalLogic P +x.xxx.xxx.xxxx M +x.xxx.xxx.xxxx S skype www.globallogic.com http://www.globallogic.com/email_disclaimer.txt