From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oleksandr Tyshchenko Subject: Re: [PATCH v1] xen/serial: Return actual bytes stored in TX FIFO for OMAP Date: Wed, 4 Nov 2015 18:09:41 +0200 Message-ID: References: <1445942183-1512-1-git-send-email-oleksandr.tyshchenko@globallogic.com> <562F652102000078000AF061@prv-mh.provo.novell.com> <562F57F9.1020805@citrix.com> <562F689C02000078000AF089@prv-mh.provo.novell.com> <562F5CCC.6080308@citrix.com> <562FB71902000078000AF499@prv-mh.provo.novell.com> <1446568569.16178.30.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1446568569.16178.30.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Julien Grall , "xen-devel@lists.xen.org" , Tim Deegan , Jan Beulich , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On Tue, Nov 3, 2015 at 6:36 PM, Ian Campbell wrote: > On Tue, 2015-10-27 at 10:40 -0600, Jan Beulich wrote: >> > > > On 27.10.15 at 17:32, wrote: >> > And what are you suggesting about the patch? Create a separate OMAP >> > specific header? >> >> For #define-s used by only a single source file I'd suggest putting >> them into the source file instead of into a (shared) header. > > I agree. (Any to be clear, any existing OMAP specific things in 8250,h > should move too). OK. I will take it into account. Thank you > > Ian. > -- Oleksandr Tyshchenko | Embedded Dev GlobalLogic www.globallogic.com