From: Jason Andryuk <jandryuk@gmail.com>
To: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
xen-devel <xen-devel@lists.xenproject.org>,
xen-devel@lists.xen.org
Subject: Re: [RFC PATCH 09/17] libxl: use \x1b to separate qemu arguments for linux stubdomain
Date: Wed, 1 Aug 2018 10:36:26 -0400 [thread overview]
Message-ID: <CAKf6xpuL1kr6GdvvVaivxo_78e7PnTaWsk6JhuC7kfB8aZ-yxw@mail.gmail.com> (raw)
In-Reply-To: <0c64341a4be3462d62b0bb5bf96b866aa18f477a.1533009377.git-series.marmarek@invisiblethingslab.com>
On Mon, Jul 30, 2018 at 11:56 PM, Marek Marczykowski-Górecki
<marmarek@invisiblethingslab.com> wrote:
> This allows using arguments with spaces, like -append.
> Stubdomain side of this require "xenstore-client: Add option for raw
> in-/output" commit.
I had to look up \x1b - it is ascii escape. Since I was on the
www.asciitable.com, I saw \x1e is "record seperator" which might make
more sense.
Either way, the code is fine. It would be good to document the
separator and other interface assumptions like the FDs in a
linux-stubdom document.
Reviewed-by: Jason Andryuk <jandryuk@gmail.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-08-01 14:36 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 3:56 [RFC PATCH 00/17] Add support for qemu-xen runnning in a Linux-based stubdomain Marek Marczykowski-Górecki
2018-07-31 3:56 ` [RFC PATCH 01/17] libxl: fix qemu-trad cmdline for no sdl/vnc case Marek Marczykowski-Górecki
2018-08-01 14:24 ` Jason Andryuk
2018-07-31 3:56 ` [RFC PATCH 02/17] libxl: Add "stubdomain_version" to domain_build_info Marek Marczykowski-Górecki
2018-08-01 14:24 ` Jason Andryuk
2018-07-31 3:56 ` [RFC PATCH 03/17] libxl: Handle Linux stubdomain specific QEMU options Marek Marczykowski-Górecki
2018-08-01 14:25 ` Jason Andryuk
2018-08-01 15:55 ` Marek Marczykowski-Górecki
2018-08-02 14:45 ` Jason Andryuk
2018-07-31 3:56 ` [RFC PATCH 04/17] libxl: Build the domain with a Linux based stubdomain Marek Marczykowski-Górecki
2018-08-01 14:26 ` Jason Andryuk
2018-08-01 14:37 ` Marek Marczykowski-Górecki
2018-08-01 14:54 ` Jason Andryuk
2018-07-31 3:56 ` [RFC PATCH 05/17] libxl: use xenstore for pci hotplug qemu-in-linux-stubdom commands Marek Marczykowski-Górecki
2018-08-01 14:29 ` Jason Andryuk
2018-08-01 16:03 ` Marek Marczykowski-Górecki
2018-08-02 14:47 ` Jason Andryuk
2018-07-31 3:56 ` [RFC PATCH 06/17] libxl: create vkb device only for guests with graphics output Marek Marczykowski-Górecki
2018-08-01 14:30 ` Jason Andryuk
2018-08-01 21:45 ` Marek Marczykowski-Górecki
2018-07-31 3:56 ` [RFC PATCH 07/17] libxl: add save/restore support for qemu-xen in stubdomain Marek Marczykowski-Górecki
2018-08-01 14:35 ` Jason Andryuk
2018-08-01 21:47 ` Marek Marczykowski-Górecki
2018-07-31 3:56 ` [RFC PATCH 08/17] xl: add stubdomain related options to xl config parser Marek Marczykowski-Górecki
2018-08-01 14:35 ` Jason Andryuk
2018-08-01 21:52 ` Marek Marczykowski-Górecki
2018-07-31 3:56 ` [RFC PATCH 09/17] libxl: use \x1b to separate qemu arguments for linux stubdomain Marek Marczykowski-Górecki
2018-08-01 14:36 ` Jason Andryuk [this message]
2018-08-01 21:54 ` Marek Marczykowski-Górecki
2018-08-02 1:45 ` Simon Gaiser
2018-08-02 1:54 ` Simon Gaiser
2018-08-02 14:30 ` Jason Andryuk
2018-07-31 3:56 ` [RFC PATCH 10/17] xenconsoled: install xenstore watch for all supported consoles Marek Marczykowski-Górecki
2018-07-31 3:56 ` [RFC PATCH 11/17] xenconsoled: add support for consoles using 'state' xenstore entry Marek Marczykowski-Górecki
2018-07-31 3:56 ` [RFC PATCH 12/17] xenconsoled: make console_type->use_gnttab less confusing Marek Marczykowski-Górecki
2018-07-31 3:56 ` [RFC PATCH 13/17] xenconsoled: add support for up to 3 secondary consoles Marek Marczykowski-Górecki
2018-07-31 3:56 ` [RFC PATCH 14/17] xenconsoled: deduplicate error handling Marek Marczykowski-Górecki
2018-07-31 3:56 ` [RFC PATCH 15/17] xenconsoled: add support for non-pty output Marek Marczykowski-Górecki
2018-07-31 3:56 ` [RFC PATCH 16/17] libxl: access QMP socket via console for qemu-in-stubdomain Marek Marczykowski-Górecki
2018-07-31 3:56 ` [RFC PATCH 17/17] libxl: use xenconsoled even for multiple stubdomain's consoles Marek Marczykowski-Górecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKf6xpuL1kr6GdvvVaivxo_78e7PnTaWsk6JhuC7kfB8aZ-yxw@mail.gmail.com \
--to=jandryuk@gmail.com \
--cc=ian.jackson@eu.citrix.com \
--cc=marmarek@invisiblethingslab.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).