xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "G.R." <firemeteor@users.sourceforge.net>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Ross Philipson <Ross.Philipson@citrix.com>,
	Jean Guyader <jean.guyader@gmail.com>,
	xen-devel <xen-devel@lists.xen.org>
Subject: Re: Need help to debug win7 BSOD on IGD passthrough
Date: Mon, 21 Jan 2013 00:26:00 +0800	[thread overview]
Message-ID: <CAKhsbWZOeAXWCSmwoOhmRkhL97r7YMenDs=+sc08nMnECrXesA@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1301151829250.4978@kaball.uk.xensource.com>

On Wed, Jan 16, 2013 at 2:40 AM, Stefano Stabellini
<stefano.stabellini@eu.citrix.com> wrote:
>> PS: it looks that the switch-on-address style of code is not very robust.
>> This would fail if the guest access using unexpected alignment && length.
>> I guess may be we should switch to a mask based implementation.
>
> Given the way QEMU emulates the PCI config space, I don't think is
> possible to receive a reads or writes with a length different from 1, 2 or
> 4 bytes.
> However I am always open to code improvements.

I'm not sure if I understand the QEMU part. But at least I've seen
this in the log:

igd_pci_read: [00:00:0] addr=0 len=4 val=1508086
igd_pci_read: [00:00:0] addr=4 len=4 val=20900006
igd_pci_read: [00:00:0] addr=8 len=4 val=6000009
igd_pci_read: [00:00:0] addr=c len=4 val=0

igd_pci_read: [00:00:0] addr=6 len=2 val=2090
igd_pci_read: [00:00:0] addr=34 len=1 val=e0
igd_pci_read: [00:00:0] addr=e0 len=2 val=9
igd_pci_read: [00:00:0] addr=4 len=2 val=6
igd_pci_read: [00:00:0] addr=4 len=2 val=6
igd_pci_read: [00:00:0] addr=c len=1 val=0
igd_pci_read: [00:00:0] addr=d len=1 val=0

There are both 2 && 4 bytes read to offset 0x4, and 2 bytes read to offset 0x6.
If we only check for 0x6 in igd_pci_read(), the 4-byte read to offset
0x4 would show inconsistent result.
But I'm not sure if this matters to SW.

  reply	other threads:[~2013-01-20 16:26 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-11  9:26 Need help to debug win7 BSOD on IGD passthrough G.R.
2013-01-04 13:49 ` G.R.
2013-01-04 15:53   ` Ross Philipson
2013-01-04 16:30     ` G.R.
2013-01-04 18:14       ` Jean Guyader
2013-01-05  5:08         ` G.R.
2013-01-06 14:16           ` G.R.
2013-01-06 15:32             ` Pasi Kärkkäinen
2013-01-07 10:38             ` Stefano Stabellini
2013-01-09 15:07               ` G.R.
2013-01-09 16:12                 ` Stefano Stabellini
2013-01-09 16:21                 ` Ian Jackson
2013-01-07 15:51             ` Ross Philipson
2013-01-09 16:37             ` Stefano Stabellini
2013-01-10 10:18               ` G.R.
2013-01-10 10:31                 ` Stefano Stabellini
2013-01-10 15:51                   ` G.R.
2013-01-11 12:56                     ` Stefano Stabellini
2013-01-15 17:12                       ` G.R.
2013-01-15 18:40                         ` Stefano Stabellini
2013-01-20 16:26                           ` G.R. [this message]
2013-01-21 10:35                             ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKhsbWZOeAXWCSmwoOhmRkhL97r7YMenDs=+sc08nMnECrXesA@mail.gmail.com' \
    --to=firemeteor@users.sourceforge.net \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=Ross.Philipson@citrix.com \
    --cc=jean.guyader@gmail.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).