From: "G.R." <firemeteor@users.sourceforge.net>
To: Ross Philipson <Ross.Philipson@citrix.com>
Cc: xen-devel <xen-devel@lists.xen.org>,
"Keir (Xen.org)" <keir@xen.org>,
Ian Campbell <Ian.Campbell@citrix.com>,
"Jean.guyader@gmail.com" <Jean.guyader@gmail.com>,
Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
Subject: Re: [PATCH] hvmloader / qemu-xen: Getting rid of resource conflict for OpRegion.
Date: Fri, 21 Dec 2012 11:59:41 +0800 [thread overview]
Message-ID: <CAKhsbWb25i14jy1dT2-U3qDS6VZmGLzd5qkkCQoftkwf7dMsPw@mail.gmail.com> (raw)
In-Reply-To: <831D55AF5A11D64C9B4B43F59EEBF720A31F6B6455@FTLPMAILBOX02.citrite.net>
On Fri, Dec 21, 2012 at 2:27 AM, Ross Philipson
<Ross.Philipson@citrix.com> wrote:
>> > Possibly with suitable macros used instead of magic numbers (e.g.,
>> > XC_PAGE_* and a macro for the opregion size).
>>
>> I guess there is no predefined macro for OpRegion size. And I guess I
>> need to define it twice for both code?
>
> In addition we should think about defining the IGD OpRegion in ACPI per the spec (cited earlier). Guest drivers seem to find the region just by reading the ASLS register in the gfx device's config space but it would be more correct to define it in ACPI too. Just a thought.
Is it a requirement for the patch to be accepted? Or, are you saying
that this should not be IGD passthrough specific?
I'm not sure what you refer to by 'ACPI' here. Is it the spec itself
or header in your source code?
I'm sorry to ask but I'm just a unlucky user trying to fix my box.
The ASLS register is just the documented way to communicate the
OpRegion you can find in the spec.
There are a lot of details in the spec. But as long as we are not
going to emulate it, only the size is relevant here, I believe.
next prev parent reply other threads:[~2012-12-21 3:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-20 3:52 [PATCH] hvmloader / qemu-xen: Getting rid of resource conflict for OpRegion G.R.
2012-12-20 3:56 ` G.R.
2012-12-20 10:41 ` Ian Campbell
2012-12-20 13:03 ` Keir Fraser
2012-12-20 13:31 ` G.R.
2012-12-20 14:19 ` Keir Fraser
2012-12-20 15:06 ` G.R.
2012-12-20 18:27 ` Ross Philipson
2012-12-21 3:59 ` G.R. [this message]
2012-12-21 15:55 ` Ross Philipson
2012-12-21 16:49 ` G.R.
2012-12-21 17:03 ` Ross Philipson
2012-12-21 17:26 ` Ross Philipson
2012-12-23 6:11 ` G.R.
2013-01-02 16:34 ` Ross Philipson
2013-01-04 7:25 ` G.R.
2013-01-09 15:34 ` G.R.
2013-01-09 16:36 ` Ross Philipson
2013-01-10 10:27 ` G.R.
2013-01-10 13:40 ` Ross Philipson
2013-01-10 16:29 ` G.R.
2013-01-14 16:01 ` Ross Philipson
2013-01-15 16:44 ` G.R.
2012-12-20 19:44 ` Jean Guyader
2012-12-20 19:50 ` Ian Campbell
2012-12-21 3:51 ` G.R.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKhsbWb25i14jy1dT2-U3qDS6VZmGLzd5qkkCQoftkwf7dMsPw@mail.gmail.com \
--to=firemeteor@users.sourceforge.net \
--cc=Ian.Campbell@citrix.com \
--cc=Jean.guyader@gmail.com \
--cc=Ross.Philipson@citrix.com \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).