Re: [PATCH v7 2/5] xen/arm: Add virtual GICv3 support

[Vijay Kilari <vijay.kilari@gmail.com>]

On Wed, Jul 16, 2014 at 5:17 PM, Ian Campbell <Ian.Campbell@citrix.com> wrote:
> On Fri, 2014-07-11 at 18:21 +0530, vijay.kilari@gmail.com wrote:
> Apart from the things Julien mentioned this looks good to me. One quick
> question:
>
> [...]
>> diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c
>> index d223db4..3647497 100644
>> --- a/xen/arch/arm/vgic.c
>> +++ b/xen/arch/arm/vgic.c
>> @@ -69,6 +69,11 @@ int domain_vgic_init(struct domain *d)
>>
>>      switch ( gic_hw_version() )
>>      {
>> +#ifdef CONFIG_ARM_64
>> +    case GIC_V3:
>> +        vgic_v3_init(d);
>> +        break;
>> +#endif
>
> With the first patch applied we will run guests on GICv3 with GICv2
> emulation. Is that expected to work (assuming suitable h/w support)?
>
> My expectation was that this wasn't enabled by this series, which is
> fine, I'm just wondering if it does just happen to work...

   Yes, this series does not support guests with GICv2. This was known
limitation.