Re: [XEN/ARM: Patch v3 1/1] Add support for the Exynos secure firmware

[Suriyan Ramasami <suriyan.r@gmail.com>]

On Mon, Sep 22, 2014 at 4:56 AM, Ian Campbell <Ian.Campbell@citrix.com> wrote:
> On Mon, 2014-09-15 at 12:34 -0700, Suriyan Ramasami wrote:
>> The existence of secure firmware is dictated by the presence of
>> "samsung,secure-firmware" in the DT.
>>
>> The Arndale board does not have that entry, and uses the address as defined
>> in "samsung,exynos4210-sysram", offset 0 as the smp init address. This is
>> possibly true for all SoCs without secure firmware.
>>
>> For other boards which do have a "secure-firmware" node, use sysram-ns
>> at offset +0x1c as the smp init address.
>>
>> The "secure-firmware" MMIO range contains ways to idle the CPU. As this gets
>> mapped to DOM0 because of its presence in the DT, we blacklist it.
>>
>> Have tested this on the Odroid XU. I have also tested the other code path
>> on the Odroid XU by removing "secure-firmware" from its DT. I could see
>> that the other code path was exercised with correct smp init address
>> values.
>>
>> Signed-off-by: Suriyan Ramasami <suriyan.r@gmail.com>
>
> I think this had already been sent when I accidentally reviewed v2
> instead. The main thing which still applies is the EXYNOS_CONFIG_NR_CPUS
> which needs to be dropped.
>
I shall drop that.

> Ideally I'd like to see exynos_smc and __invoke_psci_fn_smc become a
> common helper somewhere but I won't insist.
>
I shall pick this up when I work on the Odroid-XU3 (exynos5422 based)
XEN support, if that is OK.

I also have to remove __init_const from exynos_dt_pmu_matches[] so
that the reset code works on arndale and odroidxu.

I shall push a v4 with these changes.

Thanks!
- Suriyan

> The rest looks good, thanks.
>
> Ian.
>