From: Kyle Huey <me@kylehuey.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Robert O'Callahan <robert@ocallahan.org>,
Kevin Tian <kevin.tian@intel.com>,
Jun Nakajima <jun.nakajima@intel.com>,
Jan Beulich <JBeulich@suse.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH v2 2/2] x86/Intel: virtualize support for cpuid faulting
Date: Fri, 14 Oct 2016 12:36:19 -0700 [thread overview]
Message-ID: <CAP045Aq7Jv0qHpppM1ZkR=PknnogAjGm8+io3AucKwcYu2nMHA@mail.gmail.com> (raw)
In-Reply-To: <e5cee78f-d473-cea0-450c-3ed35e9fd161@citrix.com>
On Fri, Oct 14, 2016 at 10:18 AM, Andrew Cooper
<andrew.cooper3@citrix.com> wrote:
> On a slightly separate note, as you have just been a successful
> guinea-pig for XTF, how did you find it? It is a very new (still
> somewhat in development) system but the project is looking to try and
> improve regression testing in this way, especially for new features. I
> welcome any feedback.
It's pretty slick. Much better than what Linux has ;)
I do think it's a bit confusing that xtf_has_fep is false on PV guests.
It might also be nice to (at least optionally) have xtf_assert(cond,
message) so instead of
if ( cond )
xtf_failure(message);
you can write
xtf_assert(!cond, message);
A bonus of doing this is that the framework could actually count how
many checks were run. So for the HVM tests (which don't run the FEP
bits) instead of getting "Test result: SKIP" you could say "Test
result: 9 PASS 1 SKIP" or something similar.
- Kyle
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-10-14 19:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-13 21:09 [PATCH v2] x86/Intel: virtualize support for cpuid faulting Kyle Huey
2016-10-13 21:09 ` [PATCH v2 1/2] x86/Intel: Expose cpuid_faulting_enabled so it can be used elsewhere Kyle Huey
2016-10-14 11:51 ` Jan Beulich
2016-10-13 21:09 ` [PATCH v2 2/2] x86/Intel: virtualize support for cpuid faulting Kyle Huey
2016-10-14 12:04 ` Jan Beulich
2016-10-14 14:46 ` Andrew Cooper
2016-10-14 17:05 ` Kyle Huey
2016-10-14 17:18 ` Andrew Cooper
2016-10-14 19:28 ` Kyle Huey
2016-10-17 9:23 ` Andrew Cooper
2016-10-14 19:36 ` Kyle Huey [this message]
2016-10-17 12:34 ` Andrew Cooper
2016-10-17 16:28 ` Kyle Huey
2016-10-17 16:39 ` Andrew Cooper
2016-10-17 17:42 ` Kyle Huey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP045Aq7Jv0qHpppM1ZkR=PknnogAjGm8+io3AucKwcYu2nMHA@mail.gmail.com' \
--to=me@kylehuey.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=robert@ocallahan.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).