From: Shriram Rajagopalan <rshriram@cs.ubc.ca>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>,
Wen Congyang <wency@cn.fujitsu.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Jiang Yunhong <yunhong.jiang@intel.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
Dong Eddie <eddie.dong@intel.com>,
Hongyang Yang <yanghy@cn.fujitsu.com>
Subject: Re: [PATCH v16 2/7] remus: introduce remus device
Date: Fri, 18 Jul 2014 12:50:38 -0400 [thread overview]
Message-ID: <CAP8mzPO3AOG3uXNoNMTfLL3b3MeqHEn4V7BT9rYUiH7AzMTq7w@mail.gmail.com> (raw)
In-Reply-To: <1405700242.6419.12.camel@kazak.uk.xensource.com>
[-- Attachment #1.1: Type: text/plain, Size: 2060 bytes --]
On Fri, Jul 18, 2014 at 12:17 PM, Ian Campbell <Ian.Campbell@citrix.com>
wrote:
> On Fri, 2014-07-18 at 12:08 -0400, Shriram Rajagopalan wrote:
>
> > The keyword above is "may". Without network buffering, ongoing TCP
> > connections "may" be hung, depending on whether any communication
> > happened during the failed checkpoint. Same applies to disk.
>
> That doesn't sound like a good reason to offer this amount of rope to an
> innocent user.
>
> > If one can control the network interactions or if the application is
> > capable of recovering
> > from lost TCP connections (or lost UDP packets for that matter), then
> > it stands to benefit
> > from no-network buffering as it eliminates the latency overhead
> > introduced by buffering every
> > packet [ 0.5 x checkpoint-interval + RTT between primary-backup].
>
> Now *this* might be a reason to offer such an option for network
> traffic.
>
> But is there an existing real world requirement to support this now or
> is this just a theoretical desire? Seems like punting on it for the time
> being would let the rest of the series make progress.
>
>
Most of the if(netbuf_enabled) {} else {} is an artifact of
whether or not the host system has the correct version of libnl installed.
If autoconf said no, then libxl_nonetbuffer.c would be compiled in, but
the existence (or not) of network buffers had to be checked at various
points
in code (in libxl), especially for teardown path.
It seems harder to imagine a case where not replicating a disk would be
> tolerable.
>
Read only root file system, tmpfs based scratch file system?
Its useful to just use memory replication for testing/profiling purposes.
So i think a better alternative would be to have an explicit test flag (-t)
followed
by the no-netbuf flag (-n) and/or the no disk buffering flag (-d). Use of
a test flag
should be suggestive enough to the innocent user that this invocation is
not
meant for production, while flexible enough for someone with knowledge of
the system to disable network or disk replication for other needs.
[-- Attachment #1.2: Type: text/html, Size: 2880 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2014-07-18 16:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-15 6:46 [PATCH v16 0/7] Remus/Libxl: Remus network buffering and drbd disk Yang Hongyang
2014-07-15 6:46 ` [PATCH v16 1/7] remus: add libnl3 dependency for network buffering support Yang Hongyang
2014-07-15 6:46 ` [PATCH v16 2/7] remus: introduce remus device Yang Hongyang
2014-07-15 18:28 ` Ian Jackson
2014-07-16 10:50 ` Hongyang Yang
2014-07-16 11:46 ` Ian Jackson
2014-07-18 10:06 ` Hongyang Yang
2014-07-18 10:14 ` Ian Campbell
2014-07-18 14:24 ` Ian Jackson
2014-07-18 15:54 ` Shriram Rajagopalan
2014-07-18 15:58 ` Ian Campbell
2014-07-18 16:08 ` Shriram Rajagopalan
2014-07-18 16:17 ` Ian Campbell
2014-07-18 16:50 ` Shriram Rajagopalan [this message]
2014-07-15 6:46 ` [PATCH v16 3/7] remus netbuffer: implement remus network buffering for nic devices Yang Hongyang
2014-07-15 6:46 ` [PATCH v16 4/7] remus drbd: Implement remus drbd replicated disk Yang Hongyang
2014-07-15 6:46 ` [PATCH v16 5/7] libxl: network buffering cmdline switch Yang Hongyang
2014-07-15 6:46 ` [PATCH v16 6/7] libxl: disk " Yang Hongyang
2014-07-15 6:46 ` [PATCH v16 7/7] MAINTAINERS: Update maintained files of REMUS Yang Hongyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP8mzPO3AOG3uXNoNMTfLL3b3MeqHEn4V7BT9rYUiH7AzMTq7w@mail.gmail.com \
--to=rshriram@cs.ubc.ca \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=eddie.dong@intel.com \
--cc=laijs@cn.fujitsu.com \
--cc=wency@cn.fujitsu.com \
--cc=xen-devel@lists.xen.org \
--cc=yanghy@cn.fujitsu.com \
--cc=yunhong.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).