From: Shriram Rajagopalan <rshriram@cs.ubc.ca>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Anthony Perard <anthony.perard@citrix.com>,
"brendan@cs.ubc.ca" <brendan@cs.ubc.ca>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH 6 of 6] libxl: resume instead of unpause on xl save -c
Date: Tue, 31 Jan 2012 09:55:44 -0800 [thread overview]
Message-ID: <CAP8mzPOq00kR6-RnrSCAZuudLwtLuHTMj0fm2=njJ6s5KRiacA@mail.gmail.com> (raw)
In-Reply-To: <1328005265.26983.333.camel@zakaz.uk.xensource.com>
[-- Attachment #1.1: Type: text/plain, Size: 1464 bytes --]
On Tue, Jan 31, 2012 at 2:21 AM, Ian Campbell <Ian.Campbell@citrix.com>wrote:
> On Tue, 2012-01-31 at 01:05 +0000, rshriram@cs.ubc.ca wrote:
> > # HG changeset patch
> > # User Shriram Rajagopalan <rshriram@cs.ubc.ca>
> > # Date 1327971541 28800
> > # Node ID ffc99e708e90eb140b0a6f2e7087d567e71e9d0f
> > # Parent d79c7a853c644d459cda93bf61657be48104cd63
> > libxl: resume instead of unpause on xl save -c
> >
> > The guest is "suspended" via libxl_domain_suspend when taking a snapshot.
> > So call libxl_domain_resume instead of libxl_domain_unpause, when taking
> > a checkpoint of the domain (using xl save -c).
> >
> > Signed-off-by: Shriram Rajagopalan <rshriram@cs.ubc.ca>
>
> Does checkpoint imply/require support for this resume mechanism?
>
>
Yes. pause & unpause, suspend & resume - thats the order of calls.
A checkpoint involves
suspend_guest
copy out data
resume_guest
The current libxl code does
suspend_guest
copy out data
unpause_guest
> > diff -r d79c7a853c64 -r ffc99e708e90 tools/libxl/xl_cmdimpl.c
> > --- a/tools/libxl/xl_cmdimpl.c Mon Jan 30 16:58:53 2012 -0800
> > +++ b/tools/libxl/xl_cmdimpl.c Mon Jan 30 16:59:01 2012 -0800
> > @@ -2524,7 +2524,7 @@ static int save_domain(const char *p, co
> > close(fd);
> >
> > if (checkpoint)
> > - libxl_domain_unpause(ctx, domid);
> > + libxl_domain_resume(ctx, domid, 1);
> > else
> > libxl_domain_destroy(ctx, domid);
> >
>
>
>
[-- Attachment #1.2: Type: text/html, Size: 2320 bytes --]
[-- Attachment #2: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
prev parent reply other threads:[~2012-01-31 17:55 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-31 1:05 [PATCH 0 of 6] libxl: refactor suspend/resume code rshriram
2012-01-31 1:05 ` [PATCH 1 of 6] libxl: helper function to send commands to traditional qemu rshriram
2012-01-31 9:46 ` Ian Campbell
2012-01-31 17:30 ` Shriram Rajagopalan
2012-02-09 18:08 ` Ian Jackson
2012-01-31 1:05 ` [PATCH 2 of 6] libxl: bugfix: create_domain() return to caller if !daemonize rshriram
2012-01-31 9:47 ` Ian Campbell
2012-02-09 18:06 ` Ian Jackson
2012-01-31 1:05 ` [PATCH 3 of 6] libxl: QMP stop/resume & refactor QEMU suspend/resume/save rshriram
2012-01-31 9:54 ` Ian Campbell
2012-01-31 17:32 ` Shriram Rajagopalan
2012-01-31 23:53 ` Shriram Rajagopalan
2012-02-01 10:46 ` Ian Campbell
2012-01-31 1:05 ` [PATCH 4 of 6] libxl: support suspend_cancel in domain_resume rshriram
2012-01-31 10:00 ` Ian Campbell
2012-01-31 10:04 ` Ian Campbell
2012-01-31 17:52 ` Shriram Rajagopalan
2012-02-01 10:47 ` Ian Campbell
2012-02-01 10:53 ` Ian Campbell
2012-02-01 15:48 ` Pasi Kärkkäinen
2012-02-01 16:02 ` Ian Campbell
2012-02-01 19:30 ` Shriram Rajagopalan
2012-02-02 7:04 ` Shriram Rajagopalan
2012-02-02 7:59 ` Ian Campbell
2012-02-02 7:58 ` Ian Campbell
2012-01-31 1:05 ` [PATCH 5 of 6] libxl: refactor migrate_domain and generalize migrate_receive rshriram
2012-01-31 10:19 ` Ian Campbell
2012-01-31 1:05 ` [PATCH 6 of 6] libxl: resume instead of unpause on xl save -c rshriram
2012-01-31 10:21 ` Ian Campbell
2012-01-31 17:55 ` Shriram Rajagopalan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP8mzPOq00kR6-RnrSCAZuudLwtLuHTMj0fm2=njJ6s5KRiacA@mail.gmail.com' \
--to=rshriram@cs.ubc.ca \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=anthony.perard@citrix.com \
--cc=brendan@cs.ubc.ca \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).