From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shriram Rajagopalan Subject: Re: [PATCH 6 of 6] libxl: resume instead of unpause on xl save -c Date: Tue, 31 Jan 2012 09:55:44 -0800 Message-ID: References: <1328005265.26983.333.camel@zakaz.uk.xensource.com> Reply-To: rshriram@cs.ubc.ca Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6973330762589617513==" Return-path: In-Reply-To: <1328005265.26983.333.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Campbell Cc: Anthony Perard , "brendan@cs.ubc.ca" , "xen-devel@lists.xensource.com" , Ian Jackson List-Id: xen-devel@lists.xenproject.org --===============6973330762589617513== Content-Type: multipart/alternative; boundary=00151759367070d74d04b7d6aee9 --00151759367070d74d04b7d6aee9 Content-Type: text/plain; charset=ISO-8859-1 On Tue, Jan 31, 2012 at 2:21 AM, Ian Campbell wrote: > On Tue, 2012-01-31 at 01:05 +0000, rshriram@cs.ubc.ca wrote: > > # HG changeset patch > > # User Shriram Rajagopalan > > # Date 1327971541 28800 > > # Node ID ffc99e708e90eb140b0a6f2e7087d567e71e9d0f > > # Parent d79c7a853c644d459cda93bf61657be48104cd63 > > libxl: resume instead of unpause on xl save -c > > > > The guest is "suspended" via libxl_domain_suspend when taking a snapshot. > > So call libxl_domain_resume instead of libxl_domain_unpause, when taking > > a checkpoint of the domain (using xl save -c). > > > > Signed-off-by: Shriram Rajagopalan > > Does checkpoint imply/require support for this resume mechanism? > > Yes. pause & unpause, suspend & resume - thats the order of calls. A checkpoint involves suspend_guest copy out data resume_guest The current libxl code does suspend_guest copy out data unpause_guest > > diff -r d79c7a853c64 -r ffc99e708e90 tools/libxl/xl_cmdimpl.c > > --- a/tools/libxl/xl_cmdimpl.c Mon Jan 30 16:58:53 2012 -0800 > > +++ b/tools/libxl/xl_cmdimpl.c Mon Jan 30 16:59:01 2012 -0800 > > @@ -2524,7 +2524,7 @@ static int save_domain(const char *p, co > > close(fd); > > > > if (checkpoint) > > - libxl_domain_unpause(ctx, domid); > > + libxl_domain_resume(ctx, domid, 1); > > else > > libxl_domain_destroy(ctx, domid); > > > > > --00151759367070d74d04b7d6aee9 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
On Tue, Jan 31, 2012 at 2:21 AM, Ian Campbell <Ian.Campbell= @citrix.com> wrote:
On Tue, 2012-01-31 at 01:05 +0000, rshriram@cs.ubc.ca wrote:
> # HG changeset patch
> # User Shriram Rajagopalan <r= shriram@cs.ubc.ca>
> # Date 1327971541 28800
> # Node ID ffc99e708e90eb140b0a6f2e7087d567e71e9d0f
> # Parent =A0d79c7a853c644d459cda93bf61657be48104cd63
> libxl: resume instead of unpause on xl save -c
>
> The guest is "suspended" via libxl_domain_suspend when takin= g a snapshot.
> So call libxl_domain_resume instead of libxl_domain_unpause, when taki= ng
> a checkpoint of the domain (using xl save -c).
>
> Signed-off-by: Shriram Rajagopalan <rshriram@cs.ubc.ca>

Does checkpoint imply/require support for this resume mechanism?

<= br>Yes. pause & unpause, suspend & resume - thats the order of call= s.
A checkpoint involves
=A0suspend_guest
=A0 copy out data
= =A0resume_guest

The current libxl code does
=A0suspend_guest
=A0=A0 copy out data=
=A0unpause_guest

=A0
> diff -r d79c7a853c64 -r ffc99e708e90 tools/libxl/xl_cmdimpl.c
> --- a/tools/libxl/xl_cmdimpl.c =A0 =A0 =A0 =A0Mon Jan 30 16:58:53 2012= -0800
> +++ b/tools/libxl/xl_cmdimpl.c =A0 =A0 =A0 =A0Mon Jan 30 16:59:01 2012= -0800
> @@ -2524,7 +2524,7 @@ static int save_domain(const char *p, co
> =A0 =A0 =A0close(fd);
>
> =A0 =A0 =A0if (checkpoint)
> - =A0 =A0 =A0 =A0libxl_domain_unpause(ctx, domid);
> + =A0 =A0 =A0 =A0libxl_domain_resume(ctx, domid, 1);
> =A0 =A0 =A0else
> =A0 =A0 =A0 =A0 =A0libxl_domain_destroy(ctx, domid);
>



--00151759367070d74d04b7d6aee9-- --===============6973330762589617513== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --===============6973330762589617513==--