On Thu, Oct 31, 2013 at 1:21 PM, Ian Campbell <Ian.Campbell@citrix.com> wrote:

> +
> +case "$command" in
> + setup)
> + check_libnl_tools
> + check_modules
> +
> + claim_lock "pickifb"
> + setup_ifb
> + redirect_vif_traffic "$vifname" "$IFB"
> + add_plug_qdisc "$vifname" "$IFB"
> + release_lock "pickifb"
> +
> + #not using xenstore_write that automatically exits on error
> + # because we need to cleanup

whitespace inconsistency.

I seem to get this wrong again and again..

Did you mean the space trailing the second # ? or should the code block inside setup/teardown

be indented with two tabs instead of one ?

> + _xenstore_write "$XENBUS_PATH/ifb" "$IFB" || xs_write_failed "$vifname" "$IFB"
> + ;;
> + teardown)
> + : ${IFB?}

Do you mean log debug or something here?

This was to just make sure that the IFB variable was supplied as part of the environment..

Just like the two checks on top of this script..

: ${vifname?}

: ${XENBUS_PATH?}