From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shriram Rajagopalan Subject: Re: [PATCH 2 of 5 V3] tools/hotplug: Remus network buffering setup scripts Date: Thu, 31 Oct 2013 14:06:45 -0700 Message-ID: References: <0001a8222a785865b753.1382335084@athos.nss.cs.ubc.ca> <1383250908.5436.122.camel@dagon.hellion.org.uk> Reply-To: rshriram@cs.ubc.ca Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3330195193797119228==" Return-path: In-Reply-To: <1383250908.5436.122.camel@dagon.hellion.org.uk> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Andrew Cooper , Stefano Stabellini , Ian Jackson , Roger Pau Monne , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org --===============3330195193797119228== Content-Type: multipart/alternative; boundary=bcaec517cb724071d204ea0fd610 --bcaec517cb724071d204ea0fd610 Content-Type: text/plain; charset=ISO-8859-1 On Thu, Oct 31, 2013 at 1:21 PM, Ian Campbell wrote: > > + > > +case "$command" in > > + setup) > > + check_libnl_tools > > + check_modules > > + > > + claim_lock "pickifb" > > + setup_ifb > > + redirect_vif_traffic "$vifname" "$IFB" > > + add_plug_qdisc "$vifname" "$IFB" > > + release_lock "pickifb" > > + > > + #not using xenstore_write that automatically exits on error > > + # because we need to cleanup > > whitespace inconsistency. > > I seem to get this wrong again and again.. Did you mean the space trailing the second # ? or should the code block inside setup/teardown be indented with two tabs instead of one ? > > + _xenstore_write "$XENBUS_PATH/ifb" "$IFB" || xs_write_failed > "$vifname" "$IFB" > > + ;; > > + teardown) > > + : ${IFB?} > > Do you mean log debug or something here? > > This was to just make sure that the IFB variable was supplied as part of the environment.. Just like the two checks on top of this script.. " : ${vifname?} : ${XENBUS_PATH?} " --bcaec517cb724071d204ea0fd610 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
On Thu, Oct 31, 2013 at 1:21 PM, Ian Campbell <Ian.= Campbell@citrix.com> wrote:
> +
> +case "$command" in
> + =A0 =A0setup)
> + =A0 =A0 check_libnl_tools
> + =A0 =A0 check_modules
> +
> + =A0 =A0 claim_lock "pickifb"
> + =A0 =A0 setup_ifb
> + =A0 =A0 redirect_vif_traffic "$vifname" "$IFB" > + =A0 =A0 add_plug_qdisc "$vifname" "$IFB"
> + =A0 =A0 release_lock "pickifb"
> +
> + =A0 =A0 #not using xenstore_write that automatically exits on error<= br> > + =A0 =A0 # because we need to cleanup

whitespace inconsistency.


I seem to get = this wrong again and again..
Did you mean the space trailing the = second # ? or should the code block inside setup/teardown
be inde= nted with two tabs instead of one ?


> + =A0 =A0 _xenstore_write "$XENBUS_PATH/ifb" "$IFB"= ; || xs_write_failed "$vifname" "$IFB"
> + =A0 =A0 ;;
> + =A0 =A0teardown)
> + =A0 =A0 : ${IFB?}

Do you mean log debug or something here?


This was to ju= st make sure that the IFB variable was supplied as part of the environment.= .
Just like the two checks on top of this script..
&quo= t;
: ${vifname?}
: ${XENBUS_PATH?}
"
= =A0
--bcaec517cb724071d204ea0fd610-- --===============3330195193797119228== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============3330195193797119228==--