From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shriram Rajagopalan Subject: Re: about remus and xl patches Date: Mon, 16 Dec 2013 01:57:01 -0600 Message-ID: References: Reply-To: rshriram@cs.ubc.ca Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7092221508736012661==" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: wencongyang Cc: "eddie.dong" , xen-devel List-Id: xen-devel@lists.xenproject.org --===============7092221508736012661== Content-Type: multipart/alternative; boundary=047d7bdc10ec8d92e904eda22a19 --047d7bdc10ec8d92e904eda22a19 Content-Type: text/plain; charset=ISO-8859-1 On Mon, Dec 16, 2013 at 1:04 AM, wencongyang wrote: > hi, shriram > > i don't use this mail to subscribe to the list. so i don't reply the > thread. > > 1. about the script, you check some modules, but the user can build it > into the kernel.... > At the moment, I am only concerned about users who just want to run Remus on their stock distribution. (Over the last two years, a majority of Remus help requests I have received were from people who didnt have the expertise or did not want to mess with custom kernels on their test boxes :) ). So I figured if someone is smart enough to compile a module into the kernel itself, he/she would be easily able to fix the script to make Remus work in their setup :). > 2. in the function init_qdisc(), you use nl_socket_alloc() to alloc new > netlink socket, but i don't find nl_socket_free() > Good catch. Thanks! > . You don't cleanup when something fails? > I do. Check the *_teardown functions. It currently uses nl_close. But I should be using nl_socket_free as it seems to invoke nl_close too. > 3. in the function get_guest_vif_list(), you call get_vifname() in LOG(), > you don't free the memory. > > > No need to, AFAIK. get_vifname allocates the string in gc context. Besides, get_vif_list (and subsequently get_vifname) is a one time call during net buffer setup, i.e., before Remus starts. --047d7bdc10ec8d92e904eda22a19 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
On M= on, Dec 16, 2013 at 1:04 AM, wencongyang <wencongyang@gmail.com>= ; wrote:
hi, shriram

i don't use this mail to subscribe to the list. so i don't reply th= e thread.

1. about the script, you check some modules, but the user can build it into= the kernel....

At the moment, I am onl= y concerned about users who just want to run Remus on their stock distribut= ion.
(Over the last two years, a majority of Remus help requests I have rec= eived were from people who didnt have the expertise=A0
or did not= want to mess with custom kernels on their test boxes :) ). So I figured if= someone is smart enough to compile
a module into the kernel itself, he/she would be easily able to fix th= e script to make Remus work in their setup :).

=A0=
2. in the function init_qdisc(), you use nl_socket_alloc() to alloc new net= link socket, but i don't find nl_socket_free()
Good catch. Thanks!
=A0
. =A0You don't cleanup when something fails?

<= /div>
I do. Check the *_teardown functions. It currently uses nl_close.= But I should be using nl_socket_free as it seems to invoke
nl_cl= ose too.
=A0
3. in the function get_guest_vif_list(), you call get_vifname() in LOG(), y= ou don't free the memory.



No need to, AFAIK. =A0get_vifname allo= cates the string in gc context. Besides, get_vif_list (and subsequently get= _vifname) is a
one time call during net buffer setup, i.e., befor= e Remus starts.

=A0

--047d7bdc10ec8d92e904eda22a19-- --===============7092221508736012661== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============7092221508736012661==--