From: "Roger Pau Monné" <roger.pau@entel.upc.edu>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Ian Jackson <ian.jackson@eu.citrix.com>
Subject: Re: [PATCH 15/20] libxl: include <_libxl_paths.h> in libxl_internal.h
Date: Tue, 20 Mar 2012 23:20:38 +0000 [thread overview]
Message-ID: <CAPLaKK7utMpk34TmXNFRPzXNWkC8mv3h6dVD5FSMns=mDjEC2Q@mail.gmail.com> (raw)
In-Reply-To: <1332245590.9223.236.camel@zakaz.uk.xensource.com>
2012/3/20 Ian Campbell <Ian.Campbell@citrix.com>:
> On Fri, 2012-03-16 at 16:26 +0000, Ian Jackson wrote:
>> Ie, we permit general code in libxl direct access to the manifest
>> constants such as XEN_RUN_DIR. This simplifies their use in (eg)
>> format strings.
>>
>> This might be controversial because it will make it difficult to make
>> any of these runtime-configurable later without changing lots of use
>> sites. But I don't think it's likely we'll want to do that.
>
> I don't have any particular feeling one way or the other about this
>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
_libxl_paths.h should be generated before trying to use
libxl_internal.h, if not the build fails.
8<-------------------------------------------------------------
libxl: add _libxl_paths.h as a prerequisite to libxl_internal.h
Signed-off-by: Roger Pau Monne <roger.pau@entel.upc.edu>
---
tools/libxl/Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile
index b30d11f..c0f83a9 100644
--- a/tools/libxl/Makefile
+++ b/tools/libxl/Makefile
@@ -106,7 +106,7 @@ libxl_paths.c: _libxl_paths.h
libxl.h: _libxl_types.h
libxl_json.h: _libxl_types_json.h
-libxl_internal.h: _libxl_types_internal.h
+libxl_internal.h: _libxl_types_internal.h _libxl_paths.h
libxl_internal_json.h: _libxl_types_internal_json.h
$(LIBXL_OBJS) $(LIBXLU_OBJS) $(XL_OBJS): libxl.h
--
1.7.2.5
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2012-03-20 23:20 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 16:26 [RFC PATCH 00/20] libxl child process handling Ian Campbell <Ian.Campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com> Ian Jackson
2012-03-16 16:26 ` [PATCH 01/20] libxl: ao: allow immediate completion Ian Jackson
2012-03-19 17:29 ` Ian Campbell
2012-03-16 16:26 ` [PATCH 02/20] libxl: fix hang due to libxl__initiate_device_remove Ian Jackson
2012-03-19 17:29 ` Ian Campbell
2012-03-16 16:26 ` [PATCH 03/20] libxl: Fix eventloop_iteration over-locking Ian Jackson
2012-03-19 17:31 ` Ian Campbell
2012-03-19 17:48 ` Ian Jackson
2012-03-20 9:44 ` Ian Campbell
2012-03-16 16:26 ` [PATCH 04/20] libxl: Fix leak of ctx->lock Ian Jackson
2012-03-16 16:26 ` [PATCH 05/20] libxl: abolish libxl_ctx_postfork Ian Jackson
2012-03-16 16:26 ` [PATCH 06/20] tools: Correct PTHREAD options in config/StdGNU.mk Ian Jackson
2012-03-17 15:41 ` Roger Pau Monné
2012-03-19 16:34 ` Ian Jackson
2012-03-20 9:43 ` Ian Campbell
2012-03-20 16:05 ` Ian Jackson
2012-03-20 16:37 ` Tim Deegan
[not found] ` <CAPLaKK4+TRroEox2ScUS=NZ7G7NZ4D2wpmvDZEjST5AGByRwUg@mail.gmail.com>
2012-03-20 16:47 ` Roger Pau Monné
2012-03-20 16:55 ` Ian Campbell
2012-03-16 16:26 ` [PATCH 07/20] libxl: Use PTHREAD_CFLAGS, LDFLAGS, LIBS Ian Jackson
2012-03-20 9:43 ` Ian Campbell
2012-03-16 16:26 ` [PATCH 08/20] tools: Use PTHREAD_CFLAGS, _LDFLAGS, _LIBS Ian Jackson
2012-03-20 9:44 ` Ian Campbell
2012-03-16 16:26 ` [PATCH 09/20] libxl: Crash (more sensibly) on malloc failure Ian Jackson
2012-03-20 10:17 ` Ian Campbell
2012-03-20 16:22 ` Ian Jackson
2012-03-20 16:25 ` Ian Campbell
2012-03-16 16:26 ` [PATCH 10/20] libxl: Make libxl__zalloc et al tolerate a NULL gc Ian Jackson
2012-03-20 10:21 ` Ian Campbell
2012-03-20 16:26 ` Ian Jackson
2012-03-20 16:34 ` Ian Campbell
2012-03-16 16:26 ` [PATCH 11/20] libxl: Introduce some convenience macros Ian Jackson
2012-03-20 11:37 ` Ian Campbell
2012-03-20 16:39 ` Ian Jackson
2012-03-20 16:44 ` Ian Campbell
2012-03-16 16:26 ` [PATCH 12/20] libxl: Protect fds with CLOEXEC even with forking threads Ian Jackson
2012-03-20 11:53 ` Ian Campbell
2012-03-20 16:59 ` Ian Jackson
2012-03-16 16:26 ` [PATCH 13/20] libxl: libxl_event.c:beforepoll_internal, REQUIRE_FDS Ian Jackson
2012-03-20 12:06 ` Ian Campbell
2012-03-16 16:26 ` [PATCH 14/20] libxl: include <ctype.h> and introduce CTYPE helper macro Ian Jackson
2012-03-20 12:12 ` Ian Campbell
2012-03-20 17:02 ` Ian Jackson
2012-03-16 16:26 ` [PATCH 15/20] libxl: include <_libxl_paths.h> in libxl_internal.h Ian Jackson
2012-03-20 12:13 ` Ian Campbell
2012-03-20 23:20 ` Roger Pau Monné [this message]
2012-03-20 23:57 ` Roger Pau Monné
2012-03-21 11:31 ` Ian Jackson
2012-03-21 12:10 ` Roger Pau Monné
2012-03-21 12:20 ` Ian Jackson
2012-03-16 16:26 ` [PATCH 16/20] libxl: event API: new facilities for waiting for subprocesses Ian Jackson
2012-03-20 12:47 ` Ian Campbell
2012-03-20 17:24 ` Ian Jackson
2012-03-20 17:39 ` Ian Campbell
2012-03-21 11:26 ` Ian Jackson
2012-03-16 16:26 ` [PATCH 17/20] libxl: Provide libxl_string_list_length Ian Jackson
2012-03-20 12:48 ` Ian Campbell
2012-03-16 16:26 ` [PATCH 18/20] libxl: Introduce libxl__sendmsg_fds and libxl__recvmsg_fds Ian Jackson
2012-03-20 12:51 ` Ian Campbell
2012-03-16 16:26 ` [PATCH 19/20] libxl: Clean up setdefault in do_domain_create Ian Jackson
2012-03-16 19:08 ` Ian Campbell
2012-03-16 16:26 ` [PATCH 20/20] libxl: ao: Convert libxl_run_bootloader Ian Jackson
2012-03-20 13:49 ` Ian Campbell
2012-03-20 17:36 ` Ian Jackson
2012-03-21 12:17 ` Ian Jackson
2012-03-21 12:25 ` Ian Campbell
2012-03-21 13:19 ` Ian Jackson
2012-03-22 15:36 ` Roger Pau Monné
2012-03-22 16:27 ` Ian Jackson
2012-03-22 16:36 ` Roger Pau Monné
2012-03-22 16:37 ` Roger Pau Monné
2012-03-22 17:02 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPLaKK7utMpk34TmXNFRPzXNWkC8mv3h6dVD5FSMns=mDjEC2Q@mail.gmail.com' \
--to=roger.pau@entel.upc.edu \
--cc=Ian.Campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).