Re: [PATCH v4] libxl: handle failure of xc_version() in libxl_get_version_info()

[Harmandeep Kaur <write.harmandeep@gmail.com>]

On Tue, Mar 1, 2016 at 7:18 PM, Ian Jackson <Ian.Jackson@eu.citrix.com> wrote:
> Harmandeep Kaur writes ("[PATCH v4] libxl: handle failure of xc_version() in libxl_get_version_info()"):
>> Check the return value of xc_version() and return NULL if it
>> fails. libxl_get_version_info() can also return NULL now.
>>
>> Callers of the function libxl_get_version_info() are already
>> prepared to deal with a NULL return value.
>
> Thanks for your submission.
>
>>      long xen_version;
>> +    long r = 0;
>
> Why did you choose `long' for the type of `r' ?  Normally it would be
> an int and AFAICT xc_version returns int.

"xen_version" is already using long. Thats the only reason I used long
fot 'r' . We can make int r , no issues there.
>
>> v3: Group all calls to xc_version() , so that data copies in
>>     various info fields only if all calls to xc_version work.
>
> This should be in the main part of the commit message, and also the
> explanation of why it is necessary.
>
> Thanks,
> Ian.

Thanks for the help.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel