From: Keir Fraser <keir@xen.org>
To: Ian Campbell <Ian.Campbell@citrix.com>,
Roger Pau Monne <roger.pau@entel.upc.edu>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH v2] libxl: add support for yajl 2.x
Date: Thu, 22 Dec 2011 15:48:29 +0000 [thread overview]
Message-ID: <CB1901CD.36815%keir@xen.org> (raw)
In-Reply-To: <1324567687.7877.91.camel@zakaz.uk.xensource.com>
On 22/12/2011 15:28, "Ian Campbell" <Ian.Campbell@citrix.com> wrote:
>> diff -r f72b99fccfca -r 716d6d48e647 Config.mk
>> --- a/Config.mk Tue Dec 20 08:31:40 2011 +0100
>> +++ b/Config.mk Tue Dec 20 13:52:55 2011 +0100
>> @@ -186,6 +186,11 @@ CONFIG_LIBICONV := $(shell export OS="
>> . $(XEN_ROOT)/tools/check/funcs.sh; \
>> has_lib libiconv.so && echo 'y' || echo 'n')
>>
>> +CONFIG_YAJL_VERSION := $(shell export OS="`uname -s`"; \
>> + export CHECK_INCLUDES="$(CHECK_INCLUDES)"; \
>> + . $(XEN_ROOT)/tools/check/funcs.sh; \
>> + has_header yajl/yajl_version.h && echo 'y' || echo
>> 'n')
>
> We've ended up with a few of this sort of thing recently. I wonder if it
> is time to have a configuration/check phase which generates a config.h?
Perhaps there should be autotools machinery at the root of the tree, in
place of Config.mk etc? It seems the popular choice.
-- Keir
next prev parent reply other threads:[~2011-12-22 15:48 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-20 12:53 [PATCH v2] libxl: add support for yajl 2.x Roger Pau Monne
2011-12-22 15:28 ` Ian Campbell
2011-12-22 15:48 ` Keir Fraser [this message]
2011-12-22 15:52 ` Ian Campbell
2011-12-22 16:41 ` Roger Pau Monné
2011-12-22 17:26 ` Ian Campbell
2011-12-23 8:22 ` Roger Pau Monné
2011-12-23 8:40 ` Keir Fraser
2011-12-23 10:50 ` Ian Campbell
2011-12-23 10:58 ` Keir Fraser
2011-12-23 11:18 ` Roger Pau Monné
2011-12-23 10:45 ` Ian Campbell
2012-01-03 18:01 ` Ian Jackson
2012-01-03 18:14 ` Roger Pau Monné
2012-01-04 11:22 ` Ian Jackson
2012-01-03 18:00 ` Ian Jackson
2012-01-23 10:47 ` Ian Campbell
2012-01-23 11:30 ` Roger Pau Monné
2012-01-23 11:39 ` Ian Campbell
2012-01-23 11:59 ` Roger Pau Monné
2012-01-23 13:14 ` Ian Campbell
2012-01-23 13:21 ` Roger Pau Monné
2012-01-24 18:24 ` Ian Jackson
2012-01-25 10:11 ` Roger Pau Monné
2012-01-25 12:09 ` Ian Jackson
2012-01-24 18:23 ` Ian Jackson
2012-01-25 10:02 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CB1901CD.36815%keir@xen.org \
--to=keir@xen.org \
--cc=Ian.Campbell@citrix.com \
--cc=roger.pau@entel.upc.edu \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).