From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir@xen.org>
Subject: Re: [PATCH v2] libxl: add support for yajl 2.x
Date: Thu, 22 Dec 2011 15:48:29 +0000
Message-ID: <CB1901CD.36815%keir@xen.org>
References: <1324567687.7877.91.camel@zakaz.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <1324567687.7877.91.camel@zakaz.uk.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ian Campbell <Ian.Campbell@citrix.com>, Roger Pau Monne <roger.pau@entel.upc.edu>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 22/12/2011 15:28, "Ian Campbell" <Ian.Campbell@citrix.com> wrote:

>> diff -r f72b99fccfca -r 716d6d48e647 Config.mk
>> --- a/Config.mk Tue Dec 20 08:31:40 2011 +0100
>> +++ b/Config.mk Tue Dec 20 13:52:55 2011 +0100
>> @@ -186,6 +186,11 @@ CONFIG_LIBICONV   := $(shell export OS="
>>                         . $(XEN_ROOT)/tools/check/funcs.sh; \
>>                         has_lib libiconv.so && echo 'y' || echo 'n')
>>  
>> +CONFIG_YAJL_VERSION := $(shell export OS="`uname -s`"; \
>> +                       export CHECK_INCLUDES="$(CHECK_INCLUDES)"; \
>> +                       . $(XEN_ROOT)/tools/check/funcs.sh; \
>> +                       has_header yajl/yajl_version.h && echo 'y' || echo
>> 'n')
> 
> We've ended up with a few of this sort of thing recently. I wonder if it
> is time to have a configuration/check phase which generates a config.h?

Perhaps there should be autotools machinery at the root of the tree, in
place of Config.mk etc? It seems the popular choice.

 -- Keir