From: Keir Fraser <keir@xen.org>
To: Tim Deegan <tim@xen.org>
Cc: xen-devel@lists.xensource.com, David Vrabel <david.vrabel@citrix.com>
Subject: Re: [PATCH] x86: emulate lea with two register operands correctly
Date: Thu, 05 Jan 2012 19:03:09 +0000 [thread overview]
Message-ID: <CB2BA46D.36EF5%keir@xen.org> (raw)
In-Reply-To: <20120105160641.GB87519@ocelot.phlegethon.org>
On 05/01/2012 16:06, "Tim Deegan" <tim@xen.org> wrote:
> At 15:49 +0000 on 05 Jan (1325778595), Keir Fraser wrote:
>> On 05/01/2012 15:03, "David Vrabel" <david.vrabel@citrix.com> wrote:
>>
>>> An lea instruction with two register operands should raise an
>>> undefined instruction exception.
>>>
>>> Skype does such a instruction and will crash when starting if it does
>>> not get the exception.
>>
>> Thanks. I think it is a little nicer to check ea.type != OP_MEM, so I made
>> that change before committing this patch. It's now in xen-unstable staging.
>>
>> It's a bit concerning that we're emulating LEA at all, perhaps. I wonder if
>> a pagetable page has been reused as a code page and we didn't notice yet? Or
>> is there some other reason that skype is getting emulated? :-)
>
> #UD exceptions in HVM are passed to the emulator (IIRC as part of the
> cross-vendor migration patches, so SYSENTER & friends could be managed).
Duh, good point.
-- Keir
> Tim.
next prev parent reply other threads:[~2012-01-05 19:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-05 15:03 [PATCH] x86: emulate lea with two register operands correctly David Vrabel
2012-01-05 15:49 ` Keir Fraser
2012-01-05 16:06 ` Tim Deegan
2012-01-05 19:03 ` Keir Fraser [this message]
2012-01-05 16:17 ` David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CB2BA46D.36EF5%keir@xen.org \
--to=keir@xen.org \
--cc=david.vrabel@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).