From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir@xen.org>
Subject: Re: [PATCH] unlzo: fix input buffer free
Date: Mon, 23 Jan 2012 13:38:18 +0000
Message-ID: <CB43134A.37F36%keir@xen.org>
References: <4F1D6E02020000780006E684@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4F1D6E02020000780006E684@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Jan Beulich <JBeulich@suse.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Cc: s.hauer@pengutronix.de
List-Id: xen-devel@lists.xenproject.org

On 23/01/2012 13:26, "Jan Beulich" <JBeulich@suse.com> wrote:

> unlzo modifies the pointer to in_buf, so we have to free the original
> buffer, not the modified pointer.
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Keir Fraser <keir@xen.org>

> --- a/xen/common/unlzo.c
> +++ b/xen/common/unlzo.c
> @@ -254,7 +254,7 @@ STATIC int INIT unlzo(u8 *input, unsigne
> ret = 0;
>  exit_2:
> if (!input)
> -  free(in_buf);
> +  free(in_buf_save);
>  exit_1:
> if (!output)
> free(out_buf);
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel