From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH 3/3] xenoprof: Make the escape code consistent across 32 and 64-bit xen Date: Mon, 23 Jan 2012 17:31:28 +0000 Message-ID: References: <1327337503.26455.314.camel@elijah> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1327337503.26455.314.camel@elijah> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: George Dunlap , Jan Beulich Cc: George Dunlap , Marcus Granado , xen-devel , Ian Campbell List-Id: xen-devel@lists.xenproject.org On 23/01/2012 16:51, "George Dunlap" wrote: > On Mon, 2012-01-23 at 16:30 +0000, Jan Beulich wrote: >>> The attached patch fixes the build (with the original patch un-reverted >>> of course), by making the internal calls explicitly take 64-bit values >>> for eip, rather than "unsigned long". Will that suffice? >> >> Looks correct and sufficient, but with the original patch already >> reverted folding the changes here into the original and re-submitting >> would probably the best route to go. > > I really prefer to keep patches with no functional change separate from > those with a pretty major functional change; even if the major > functional change is only one line. :-) The one-line major functional change didn't work. Obviously the other changes to make it build must be part of the same logical patch. -- Keir