From: Keir Fraser <keir.xen@gmail.com>
To: Tim Deegan <tim@xen.org>, xen-devel@lists.xensource.com
Subject: Re: [PATCH] Get rid of non-static 'inline' modifiers (gcc 4.2.1 complains)
Date: Thu, 26 Jan 2012 15:59:02 +0000 [thread overview]
Message-ID: <CB4728C6.29A7A%keir.xen@gmail.com> (raw)
In-Reply-To: <20120126154704.GB80228@ocelot.phlegethon.org>
On 26/01/2012 15:47, "Tim Deegan" <tim@xen.org> wrote:
> # HG changeset patch
> # User Tim Deegan <tim@xen.org>
> # Date 1327592560 0
> # Node ID dba361080715baf5ec2c493190bb69ba04cc633c
> # Parent a08043a997ea550e351ee87cd205f87562c67fcb
> Get rid of non-static 'inline' modifiers (gcc 4.2.1 complains)
>
> They seem to have been introduced by accident in 23311:f4585056b9ae
> when some 'static inline' functions were moved out of a header
>
> Signed-off-by: Tim Deegan <tim@xen.org>
Acked-by: Keir Fraser <keir@xen.org>
> diff -r a08043a997ea -r dba361080715 xen/arch/x86/xstate.c
> --- a/xen/arch/x86/xstate.c Thu Jan 26 15:35:36 2012 +0000
> +++ b/xen/arch/x86/xstate.c Thu Jan 26 15:42:40 2012 +0000
> @@ -40,13 +40,13 @@ static inline void xsetbv(u32 index, u64
> "a" (lo), "d" (hi));
> }
>
> -inline void set_xcr0(u64 xfeatures)
> +void set_xcr0(u64 xfeatures)
> {
> this_cpu(xcr0) = xfeatures;
> xsetbv(XCR_XFEATURE_ENABLED_MASK, xfeatures);
> }
>
> -inline uint64_t get_xcr0(void)
> +uint64_t get_xcr0(void)
> {
> return this_cpu(xcr0);
> }
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
prev parent reply other threads:[~2012-01-26 15:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-26 15:47 [PATCH] Get rid of non-static 'inline' modifiers (gcc 4.2.1 complains) Tim Deegan
2012-01-26 15:59 ` Keir Fraser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CB4728C6.29A7A%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).