From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [xen-unstable bisection] complete build-amd64 Date: Thu, 26 Jan 2012 17:38:43 +0000 Message-ID: References: <20257.36117.343474.863135@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20257.36117.343474.863135@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Jackson , Olaf Hering , Andres Lagar-Cavilla Cc: "xen-devel@lists.xensource.com" , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On 26/01/2012 17:27, "Ian Jackson" wrote: > xen.org writes ("[xen-unstable bisection] complete build-amd64"): >> branch xen-unstable >> xen branch xen-unstable >> job build-amd64 >> test xen-build >> >> Tree: qemu git://xenbits.xen.org/staging/qemu-xen-unstable.git >> Tree: xen http://xenbits.xen.org/staging/xen-unstable.hg >> >> *** Found and reproduced problem changeset *** >> >> Bug is in tree: xen http://xenbits.xen.org/staging/xen-unstable.hg >> Bug introduced: d5b706214616 >> Bug not present: 1e27e827e6a8 >> >> >> changeset: 24566:d5b706214616 >> user: Olaf Hering >> date: Thu Jan 26 11:04:59 2012 +0000 >> >> tools/libxc: fix error handling in xc_mem_paging_load >> >> xc_mem_paging_load() does not pass errors in errno and the actual >> errno from xc_mem_event_control() is overwritten by munlock(). >> xenpaging_populate_page() needs to check errno, but with the switch to >> xc_mem_paging_load() it could not receive ENOMEM anymore. >> >> Update xc_mem_paging_load() to return -1 and preserve errno during >> munlock(). >> >> Signed-off-by: Olaf Hering >> Acked-by: Andres Lagar-Cavilla >> Committed-by: Keir Fraser > > cc1: warnings being treated as errors > xc_mem_paging.c: In function 'xc_mem_paging_load': > xc_mem_paging.c:90: error: statement with no effect > make[3]: *** [xc_mem_paging.o] Error 1 > make[3]: Leaving directory > `/home/osstest/build.11617.build-amd64/xen-unstable/stubdom/libxc-x86_64' > make[2]: *** [build] Error 2 > make[2]: Leaving directory > `/home/osstest/build.11617.build-amd64/xen-unstable/stubdom/libxc-x86_64' > make[1]: *** [libxc-x86_64/libxenctrl.a] Error 2 > make[1]: *** Waiting for unfinished jobs.... Tim already fixed it. -- Keir