From: Keir Fraser <keir.xen@gmail.com>
To: Dietmar Hahn <dietmar.hahn@ts.fujitsu.com>,
xen-devel@lists.xensource.com
Subject: Re: [PATCH] vpmu: Is CONFIG_SMP used anymore?
Date: Wed, 08 Feb 2012 05:57:28 +0000 [thread overview]
Message-ID: <CB57BF48.2A9B6%keir.xen@gmail.com> (raw)
In-Reply-To: <2192614.Ifr2rPImK0@amur>
On 08/02/2012 13:14, "Dietmar Hahn" <dietmar.hahn@ts.fujitsu.com> wrote:
> Hi,
>
> while locking at the vpmu stuff I found the following stuff:
>
> diff -r a55e0f9c7b4e xen/arch/x86/oprofile/nmi_int.c
> --- a/xen/arch/x86/oprofile/nmi_int.c Wed Feb 08 12:28:47 2012 +0100
> +++ b/xen/arch/x86/oprofile/nmi_int.c Wed Feb 08 14:11:06 2012 +0100
> @@ -305,7 +305,7 @@ static int __init p4_init(char ** cpu_ty
> }
>
> #ifndef CONFIG_SMP
> - *cpu_type = "i386/p4", XENOPROF_CPU_TYPE_SIZE);
> + *cpu_type = "i386/p4";
> model = &op_p4_spec;
> return 1;
> #else
>
>
> Is CONFIG_SMP always switched on? It seems nobody tested without CONFIG_SMP.
Correct. !CONFIG_SMP isn't configurable or supported.
-- Keir
> Thanks.
>
> Dietmar.
>
next prev parent reply other threads:[~2012-02-08 5:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 13:14 [PATCH] vpmu: Is CONFIG_SMP used anymore? Dietmar Hahn
2012-02-08 5:57 ` Keir Fraser [this message]
2012-02-08 14:05 ` Andrew Cooper
2012-02-08 6:09 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CB57BF48.2A9B6%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=dietmar.hahn@ts.fujitsu.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).