From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: Mini-os fbfront.c unused variable complaint Date: Wed, 08 Feb 2012 07:19:03 +0000 Message-ID: References: <1328710520.6133.36.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1328710520.6133.36.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Campbell , John McDermott CIV Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 08/02/2012 14:15, "Ian Campbell" wrote: > On Mon, 2012-02-06 at 19:05 +0000, John McDermott CIV wrote: >> Xen Developers, >> >> FWIW, in trying to compile mini-os on Xen 4.1.2, I get a variable set >> but not used warning for variable 'message' in function init_kbdfront. >> (Looks like another one just like it, in function init_fbfront, from >> the same file.) My source won't compile with these warnings. I could >> not find a patch for this in xen-4.1-testing.hg Xenbits. > > This new, enabled by default, compiler warning is very annoying, even > though it happens to be correct. Which distro has done it? (or maybe > it's just new enough gcc which is to blame). We should be disablign this warning in Config.mk, where we add -Wno-unused-but-set-variable to CFLAGS. Perhaps mini-os needs to do the same, if it is creating its own CFLAGS? Note that we add it in Config.mk via $(call cc-option-add ...) because older gcc versions do not have this warning. -- Keir >> It looks like a conditional printk got left out after the label >> 'abort_transaction'. I don't understand fbfront.c well enough to >> suggest a patch. Its low priority for me, because I am going to stick >> some plausible code in there for now. > > I think an unconditional printk including the %s and message is all > which is required here. If you've got some plausible code you may as > well post it. > > Thanks, > Ian. > >> >> Sincerely, >> >> John >> ---- >> What is the formal meaning of the one-line program >> #include "/dev/tty" >> >> J.P. McDermott building 12 >> Code 5542 john.mcdermott@nrl.navy.mil >> Naval Research Laboratory voice: +1 202.404.8301 >> Washington, DC 20375, US fax: +1 202.404.7942 >> >> >> >> >> >> >> >> >> >> >> >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@lists.xensource.com >> http://lists.xensource.com/xen-devel > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel