From: Keir Fraser <keir@xen.org>
To: Julian Pidancet <julian.pidancet@gmail.com>,
xen-devel@lists.xensource.com
Cc: Ian.Campbell@citrix.com
Subject: Re: [PATCH v3 0/5] hvmloader: Make ROM dependencies optional
Date: Mon, 13 Feb 2012 12:51:54 +0000 [thread overview]
Message-ID: <CB5EB7EA.3933E%keir@xen.org> (raw)
In-Reply-To: <cover.1328991838.git.julian.pidancet@gmail.com>
On 11/02/2012 20:39, "Julian Pidancet" <julian.pidancet@gmail.com> wrote:
> This patch set mainly allows the user to build a seabios or rombios only
> version of hvmloader.
> In addition, when building a seabios only hvmloader, Option ROMs like
> vgabios and etherboot are no longer required, and therefore can be disabled
> from the build. Dependency on the bcc compiler can also be avoided the
> same way.
Applied, but I wonder why we still have the rombios support? Could we switch
over to seabios for 4.2 and get rid of the crufty old rombios code entirely?
-- Keir
> v2: Separate patches for separate issues
> Introduced config option to select which NIC to build ROM for
> Fixed initial patch to build multiple etherboot ROMs in hvmloader
> Option ROMs are keyed off wether or not rombios is enabled, rather than
> on an individual basis
> Introduced config options to select support for rombios/seabios
>
> v3: Fix mkhex script to take several file arguments on the command line
> Reorganize hvmloader option ROM loading code to make it optionnal, and
> make bios->load_roms a callback that the BIOS support code has to implement
> if option ROM loading is desired.
> Cosmetic change in tools/firmware/Makefile in the way seabios-dir is
> created.
>
> Julian Pidancet (5):
> hvmloader: Only compile 32bitbios_support.c when rombios is enabled
> hvmloader: Allow the mkhex command to take several file arguments
> firmware: Use mkhex from hvmloader directory for etherboot ROMs
> hvmloader: Move option ROM loading into a separate optionnal file
> firmware: Introduce CONFIG_ROMBIOS and CONFIG_SEABIOS options
>
> Config.mk | 5 +
> tools/firmware/Makefile | 18 ++--
> tools/firmware/etherboot/Config | 2 -
> tools/firmware/etherboot/Makefile | 13 +--
> tools/firmware/hvmloader/Makefile | 39 ++++---
> tools/firmware/hvmloader/config.h | 3 +-
> tools/firmware/hvmloader/hvmloader.c | 218
> +--------------------------------
> tools/firmware/hvmloader/mkhex | 3 +-
> tools/firmware/hvmloader/option_rom.h | 7 +
> tools/firmware/hvmloader/optionroms.c | 189 ++++++++++++++++++++++++++++
> tools/firmware/hvmloader/rombios.c | 63 +++++++++-
> tools/firmware/hvmloader/seabios.c | 5 +-
> 12 files changed, 302 insertions(+), 263 deletions(-)
> create mode 100644 tools/firmware/hvmloader/optionroms.c
next prev parent reply other threads:[~2012-02-13 12:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-11 20:39 [PATCH v3 0/5] hvmloader: Make ROM dependencies optional Julian Pidancet
2012-02-11 20:39 ` [PATCH v3 1/5] hvmloader: Only compile 32bitbios_support.c when rombios is enabled Julian Pidancet
2012-02-13 11:51 ` Ian Campbell
2012-02-11 20:39 ` [PATCH v3 2/5] hvmloader: Allow the mkhex command to take several file arguments Julian Pidancet
2012-02-13 11:51 ` Ian Campbell
2012-02-11 20:39 ` [PATCH v3 3/5] firmware: Use mkhex from hvmloader directory for etherboot ROMs Julian Pidancet
2012-02-13 11:52 ` Ian Campbell
2012-02-11 20:39 ` [PATCH v3 4/5] hvmloader: Move option ROM loading into a separate optionnal file Julian Pidancet
2012-02-13 11:53 ` Ian Campbell
2012-02-11 20:39 ` [PATCH v3 5/5] firmware: Introduce CONFIG_ROMBIOS and CONFIG_SEABIOS options Julian Pidancet
2012-02-13 11:55 ` Ian Campbell
2012-02-13 12:51 ` Keir Fraser [this message]
2012-02-13 12:56 ` [PATCH v3 0/5] hvmloader: Make ROM dependencies optional Ian Campbell
2012-02-13 13:09 ` Keir Fraser
2012-02-13 13:35 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CB5EB7EA.3933E%keir@xen.org \
--to=keir@xen.org \
--cc=Ian.Campbell@citrix.com \
--cc=julian.pidancet@gmail.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).