From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH v3 0/5] hvmloader: Make ROM dependencies optional Date: Mon, 13 Feb 2012 12:51:54 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Julian Pidancet , xen-devel@lists.xensource.com Cc: Ian.Campbell@citrix.com List-Id: xen-devel@lists.xenproject.org On 11/02/2012 20:39, "Julian Pidancet" wrote: > This patch set mainly allows the user to build a seabios or rombios only > version of hvmloader. > In addition, when building a seabios only hvmloader, Option ROMs like > vgabios and etherboot are no longer required, and therefore can be disabled > from the build. Dependency on the bcc compiler can also be avoided the > same way. Applied, but I wonder why we still have the rombios support? Could we switch over to seabios for 4.2 and get rid of the crufty old rombios code entirely? -- Keir > v2: Separate patches for separate issues > Introduced config option to select which NIC to build ROM for > Fixed initial patch to build multiple etherboot ROMs in hvmloader > Option ROMs are keyed off wether or not rombios is enabled, rather than > on an individual basis > Introduced config options to select support for rombios/seabios > > v3: Fix mkhex script to take several file arguments on the command line > Reorganize hvmloader option ROM loading code to make it optionnal, and > make bios->load_roms a callback that the BIOS support code has to implement > if option ROM loading is desired. > Cosmetic change in tools/firmware/Makefile in the way seabios-dir is > created. > > Julian Pidancet (5): > hvmloader: Only compile 32bitbios_support.c when rombios is enabled > hvmloader: Allow the mkhex command to take several file arguments > firmware: Use mkhex from hvmloader directory for etherboot ROMs > hvmloader: Move option ROM loading into a separate optionnal file > firmware: Introduce CONFIG_ROMBIOS and CONFIG_SEABIOS options > > Config.mk | 5 + > tools/firmware/Makefile | 18 ++-- > tools/firmware/etherboot/Config | 2 - > tools/firmware/etherboot/Makefile | 13 +-- > tools/firmware/hvmloader/Makefile | 39 ++++--- > tools/firmware/hvmloader/config.h | 3 +- > tools/firmware/hvmloader/hvmloader.c | 218 > +-------------------------------- > tools/firmware/hvmloader/mkhex | 3 +- > tools/firmware/hvmloader/option_rom.h | 7 + > tools/firmware/hvmloader/optionroms.c | 189 ++++++++++++++++++++++++++++ > tools/firmware/hvmloader/rombios.c | 63 +++++++++- > tools/firmware/hvmloader/seabios.c | 5 +- > 12 files changed, 302 insertions(+), 263 deletions(-) > create mode 100644 tools/firmware/hvmloader/optionroms.c