xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Keir Fraser <keir@xen.org>
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] passthrough: fix domain ref leak after 24888:71159fb049f2
Date: Wed, 07 Mar 2012 09:44:49 +0000	[thread overview]
Message-ID: <CB7CDE91.3AF0A%keir@xen.org> (raw)
In-Reply-To: <4F573B670200007800076DC4@nat28.tlf.novell.com>

On 07/03/2012 09:41, "Jan Beulich" <JBeulich@suse.com> wrote:

> As pointed out by Keir.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Keir Fraser <keir@xen.org>

> --- a/xen/drivers/passthrough/iommu.c
> +++ b/xen/drivers/passthrough/iommu.c
> @@ -580,6 +580,8 @@ int iommu_do_domctl(
>              printk(XENLOG_G_ERR
>                     "XEN_DOMCTL_assign_device: get_domain_by_id() failed\n");
>              ret = -EINVAL;
> +            if ( d )
> +                goto assign_device_out;
>              break;
>          }
>  
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel

      reply	other threads:[~2012-03-07  9:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-07  9:41 [PATCH] passthrough: fix domain ref leak after 24888:71159fb049f2 Jan Beulich
2012-03-07  9:44 ` Keir Fraser [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CB7CDE91.3AF0A%keir@xen.org \
    --to=keir@xen.org \
    --cc=JBeulich@suse.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).