* [PATCH] passthrough: fix domain ref leak after 24888:71159fb049f2
@ 2012-03-07 9:41 Jan Beulich
2012-03-07 9:44 ` Keir Fraser
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2012-03-07 9:41 UTC (permalink / raw)
To: xen-devel
[-- Attachment #1: Type: text/plain, Size: 446 bytes --]
As pointed out by Keir.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/drivers/passthrough/iommu.c
+++ b/xen/drivers/passthrough/iommu.c
@@ -580,6 +580,8 @@ int iommu_do_domctl(
printk(XENLOG_G_ERR
"XEN_DOMCTL_assign_device: get_domain_by_id() failed\n");
ret = -EINVAL;
+ if ( d )
+ goto assign_device_out;
break;
}
[-- Attachment #2: passthrough-fix-24888.patch --]
[-- Type: text/plain, Size: 501 bytes --]
passthrough: fix domain ref leak after 24888:71159fb049f2
As pointed out by Keir.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/drivers/passthrough/iommu.c
+++ b/xen/drivers/passthrough/iommu.c
@@ -580,6 +580,8 @@ int iommu_do_domctl(
printk(XENLOG_G_ERR
"XEN_DOMCTL_assign_device: get_domain_by_id() failed\n");
ret = -EINVAL;
+ if ( d )
+ goto assign_device_out;
break;
}
[-- Attachment #3: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] passthrough: fix domain ref leak after 24888:71159fb049f2
2012-03-07 9:41 [PATCH] passthrough: fix domain ref leak after 24888:71159fb049f2 Jan Beulich
@ 2012-03-07 9:44 ` Keir Fraser
0 siblings, 0 replies; 2+ messages in thread
From: Keir Fraser @ 2012-03-07 9:44 UTC (permalink / raw)
To: Jan Beulich, xen-devel
On 07/03/2012 09:41, "Jan Beulich" <JBeulich@suse.com> wrote:
> As pointed out by Keir.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Keir Fraser <keir@xen.org>
> --- a/xen/drivers/passthrough/iommu.c
> +++ b/xen/drivers/passthrough/iommu.c
> @@ -580,6 +580,8 @@ int iommu_do_domctl(
> printk(XENLOG_G_ERR
> "XEN_DOMCTL_assign_device: get_domain_by_id() failed\n");
> ret = -EINVAL;
> + if ( d )
> + goto assign_device_out;
> break;
> }
>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-03-07 9:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-07 9:41 [PATCH] passthrough: fix domain ref leak after 24888:71159fb049f2 Jan Beulich
2012-03-07 9:44 ` Keir Fraser
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).