From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH 2 of 2] Avoid vcpu migration of paused vcpus Date: Thu, 22 Mar 2012 10:12:22 +0000 Message-ID: References: <932dc3987e3dac816d51.1332404573@nehalem1> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <932dc3987e3dac816d51.1332404573@nehalem1> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Juergen Gross , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Your original patch didn't touch this code. Was that an omission in the original version? On reflection I prefer your original patch to this new approach. I'll apply it if you still believe your original patch is complete and correct as it stands. -- Keir On 22/03/2012 08:22, "Juergen Gross" wrote: > Currently offlining a cpu will migrate all vcpus which were active on that > cpu to another one, possibly breaking existing cpu affinities. > > In case of an ACPI state change the cpus are taken offline and online later > (if not poweroff) while all domains are paused. There is no reason to > migrate the vcpus during offlining the cpus, as the cpus will be available > again when the domains are being unpaused. > > This patch defers the migration check in case of paused vcpus or domains > by adding vcpu_arouse() to wake up a vcpu and check whether it must be > migrated to another cpu. > > Signed-off-by: Juergen Gross > > > 3 files changed, 64 insertions(+), 24 deletions(-) > xen/common/domain.c | 4 +- > xen/common/schedule.c | 83 ++++++++++++++++++++++++++++++++++------------- > xen/include/xen/sched.h | 1 > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel