From: Keir Fraser <keir.xen@gmail.com>
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xen.org>
Subject: Re: checking d->grant_table against NULL?
Date: Wed, 11 Apr 2012 12:12:01 +0100 [thread overview]
Message-ID: <CBAB2591.306C4%keir.xen@gmail.com> (raw)
In-Reply-To: <4F857744020000780007D348@nat28.tlf.novell.com>
On 11/04/2012 11:21, "Jan Beulich" <JBeulich@suse.com> wrote:
> gnttab_prepare_for_transfer() is the only place in grant_table.c where
> such a check happens. Is this check superfluous (and hence slightly
> misleading), or are similar checks missing throughout the file? I suppose
> the former, given that domains get inserted to the hash table only after
> grant_table_create() ran, and get removed again before calling
> grant_table_destroy().
I agree, I'm pretty sure it's superfluous.
> Thanks, Jan
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
prev parent reply other threads:[~2012-04-11 11:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-11 10:21 checking d->grant_table against NULL? Jan Beulich
2012-04-11 11:12 ` Keir Fraser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CBAB2591.306C4%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).