From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.xen@gmail.com>
Subject: Re: checking d->grant_table against NULL?
Date: Wed, 11 Apr 2012 12:12:01 +0100
Message-ID: <CBAB2591.306C4%keir.xen@gmail.com>
References: <4F857744020000780007D348@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <4F857744020000780007D348@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 11/04/2012 11:21, "Jan Beulich" <JBeulich@suse.com> wrote:

> gnttab_prepare_for_transfer() is the only place in grant_table.c where
> such a check happens. Is this check superfluous (and hence slightly
> misleading), or are similar checks missing throughout the file? I suppose
> the former, given that domains get inserted to the hash table only after
> grant_table_create() ran, and get removed again before calling
> grant_table_destroy().

I agree, I'm pretty sure it's superfluous.

> Thanks, Jan
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel