* checking d->grant_table against NULL?
@ 2012-04-11 10:21 Jan Beulich
2012-04-11 11:12 ` Keir Fraser
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2012-04-11 10:21 UTC (permalink / raw)
To: xen-devel
gnttab_prepare_for_transfer() is the only place in grant_table.c where
such a check happens. Is this check superfluous (and hence slightly
misleading), or are similar checks missing throughout the file? I suppose
the former, given that domains get inserted to the hash table only after
grant_table_create() ran, and get removed again before calling
grant_table_destroy().
Thanks, Jan
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: checking d->grant_table against NULL?
2012-04-11 10:21 checking d->grant_table against NULL? Jan Beulich
@ 2012-04-11 11:12 ` Keir Fraser
0 siblings, 0 replies; 2+ messages in thread
From: Keir Fraser @ 2012-04-11 11:12 UTC (permalink / raw)
To: Jan Beulich, xen-devel
On 11/04/2012 11:21, "Jan Beulich" <JBeulich@suse.com> wrote:
> gnttab_prepare_for_transfer() is the only place in grant_table.c where
> such a check happens. Is this check superfluous (and hence slightly
> misleading), or are similar checks missing throughout the file? I suppose
> the former, given that domains get inserted to the hash table only after
> grant_table_create() ran, and get removed again before calling
> grant_table_destroy().
I agree, I'm pretty sure it's superfluous.
> Thanks, Jan
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-04-11 11:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-11 10:21 checking d->grant_table against NULL? Jan Beulich
2012-04-11 11:12 ` Keir Fraser
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).