From: Keir Fraser <keir@xen.org>
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] x86-64: fix updating of UREGS_rip when converting sysenter to #GP
Date: Tue, 17 Apr 2012 16:05:38 +0100 [thread overview]
Message-ID: <CBB34552.3E5A3%keir@xen.org> (raw)
In-Reply-To: <4F8DA0F4020000780007E940@nat28.tlf.novell.com>
On 17/04/2012 15:57, "Jan Beulich" <JBeulich@suse.com> wrote:
> (I spotted this copy-and-paste mistake only when backporting c/s
> 25200:80f4113be500 to 4.1 and 4.0.)
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Keir Fraser <keir@xen.org>
> --- a/xen/arch/x86/x86_64/entry.S
> +++ b/xen/arch/x86/x86_64/entry.S
> @@ -280,7 +280,7 @@ sysenter_eflags_saved:
> UNLIKELY_START(z, sysenter_gpf)
> movq VCPU_trap_ctxt(%rbx),%rsi
> movl $TRAP_gp_fault,UREGS_entry_vector(%rsp)
> - subl $2,UREGS_rip(%rsp)
> + subq $2,UREGS_rip(%rsp)
> movl %eax,TRAPBOUNCE_error_code(%rdx)
> movq TRAP_gp_fault * TRAPINFO_sizeof + TRAPINFO_eip(%rsi),%rax
> testb $4,TRAP_gp_fault * TRAPINFO_sizeof + TRAPINFO_flags(%rsi)
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
prev parent reply other threads:[~2012-04-17 15:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-17 14:57 [PATCH] x86-64: fix updating of UREGS_rip when converting sysenter to #GP Jan Beulich
2012-04-17 15:05 ` Keir Fraser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CBB34552.3E5A3%keir@xen.org \
--to=keir@xen.org \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).