From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir@xen.org>
Subject: Re: [PATCH] mem_access: fix setting default mem_access
 type
Date: Wed, 18 Apr 2012 09:32:19 +0100
Message-ID: <CBB43AA3.3E628%keir@xen.org>
References: <CAB10MZA-64tOohf5_1-8LJ52E3dUC0xOYSUPRgUgeqC3mOBhKQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CAB10MZA-64tOohf5_1-8LJ52E3dUC0xOYSUPRgUgeqC3mOBhKQ@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Aravindh Puthiyaparambil <aravindh@virtuata.com>, xen-devel@lists.xensource.com
Cc: Tim Deegan <tim@xen.org>
List-Id: xen-devel@lists.xenproject.org

On 18/04/2012 02:09, "Aravindh Puthiyaparambil" <aravindh@virtuata.com>
wrote:

> When xc_hvm_set_mem_access(xch, domain_id, default_access, ~0ull, 0)
> is called, first_pfn=~0ull is a hint to HVMOP_set_mem_access as to
> what the default mem_access type is for the domain. This call was
> failing because it was gated by the memory range check in the
> HVMOP_set_mem_access case statement in do_hvm_op(). The following
> patch fixes this issue.
> 
> Signed-off-by: Aravindh Puthiyaparambil <aravindh@virtuata.com>

Looks okay to me. Probably should be checked and applied by Tim.

 -- Keir

> ---
>  xen/arch/x86/hvm/hvm.c |  5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff -r a06e6cdeafe3 xen/arch/x86/hvm/hvm.c
> --- a/xen/arch/x86/hvm/hvm.c Mon Apr 16 13:05:28 2012 +0200
> +++ b/xen/arch/x86/hvm/hvm.c Tue Apr 17 18:03:37 2012 -0700
> @@ -4170,9 +4170,10 @@
>              goto param_fail5;
> 
>          rc = -EINVAL;
> -        if ( (a.first_pfn > domain_get_maximum_gpfn(d)) ||
> +        if ( (a.first_pfn != ~0ull) &&
> +             ((a.first_pfn > domain_get_maximum_gpfn(d)) ||
>               ((a.first_pfn + a.nr - 1) < a.first_pfn) ||
> -             ((a.first_pfn + a.nr - 1) > domain_get_maximum_gpfn(d)) )
> +             ((a.first_pfn + a.nr - 1) > domain_get_maximum_gpfn(d))) )
>              goto param_fail5;
> 
>          rc = p2m_set_mem_access(d, a.first_pfn, a.nr, a.hvmmem_access);
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel