From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] svm: Do not intercept RDTCS(P) when TSC scaling is supported by hardware Date: Wed, 25 Apr 2012 18:14:49 +0100 Message-ID: References: <4F982098.8070003@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4F982098.8070003@amd.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: wei.huang2@amd.com, Dan Magenheimer Cc: Boris Ostrovsky , Jan Beulich , xen-devel List-Id: xen-devel@lists.xenproject.org On 25/04/2012 17:04, "Wei Huang" wrote: >> I certainly don't feel comfortable ACKing it. I'd like >> to see some testing that demonstrates the patch either improves >> functionality or performance without breaking other things. >> But if nobody else shares my concern, I don't feel that >> I have the right to block it either. > > We can provide some rdtsc performance numbers. Regarding functionality, > it is relatively hard to prove unless Dan has some more specific ideas > of testing it. I think the hardware rdtsc scaling is inline with > software-based emulated approach. I've put it in to xen-unstable. I'm not sure about putting into 4.1 for the forthcoming release from that branch. -- Keir