From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: ns16550.c's poll_port variable Date: Fri, 04 May 2012 09:25:38 +0100 Message-ID: References: <4FA3ACDB0200007800081847@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4FA3ACDB0200007800081847@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel List-Id: xen-devel@lists.xenproject.org On 04/05/2012 09:18, "Jan Beulich" wrote: > Hi Keir, > > does this really need to be a per-CPU variable? Can't a timer run only > once at a time on the entire system (the more that it gets re-armed only > at the end of the poll function, whereas the variable is consumed at the > start), and hence the variable can be a simple one? Or else, what > subtlety am I overlooking? We set up a timer per initialised uart. There can be more than one (although granted it is rare). -- Keir > Thanks, Jan >