From: Keir Fraser <keir.xen@gmail.com>
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] x86/MSI: remove stray endianness definition
Date: Fri, 04 May 2012 14:25:40 +0100 [thread overview]
Message-ID: <CBC99764.325A1%keir.xen@gmail.com> (raw)
In-Reply-To: <4FA3E9530200007800081A2F@nat28.tlf.novell.com>
On 04/05/2012 13:36, "Jan Beulich" <JBeulich@suse.com> wrote:
> ... as it conflicts with the one made in asm/byteorder.h, and hence
> build fails when both happen to be included from the same source file.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Keir Fraser <keir@xen.org>
> --- a/xen/include/asm-x86/msi.h
> +++ b/xen/include/asm-x86/msi.h
> @@ -3,6 +3,7 @@
>
> #include <xen/cpumask.h>
> #include <xen/pci.h>
> +#include <asm/byteorder.h>
>
> /*
> * Constants for Intel APIC based MSI messages.
> @@ -165,8 +166,6 @@ int msi_free_irq(struct msi_desc *entry)
> #define MSI_LOGICAL_MODE 1
> #define MSI_REDIRECTION_HINT_MODE 0
>
> -#define __LITTLE_ENDIAN_BITFIELD 1
> -
> struct msg_data {
> #if defined(__LITTLE_ENDIAN_BITFIELD)
> __u32 vector : 8;
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
prev parent reply other threads:[~2012-05-04 13:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-04 12:36 [PATCH] x86/MSI: remove stray endianness definition Jan Beulich
2012-05-04 13:25 ` Keir Fraser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CBC99764.325A1%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).