From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.xen@gmail.com>
Subject: Re: [PATCH] x86/MSI: remove stray endianness definition
Date: Fri, 04 May 2012 14:25:40 +0100
Message-ID: <CBC99764.325A1%keir.xen@gmail.com>
References: <4FA3E9530200007800081A2F@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <4FA3E9530200007800081A2F@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 04/05/2012 13:36, "Jan Beulich" <JBeulich@suse.com> wrote:

> ... as it conflicts with the one made in asm/byteorder.h, and hence
> build fails when both happen to be included from the same source file.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Keir Fraser <keir@xen.org>

> --- a/xen/include/asm-x86/msi.h
> +++ b/xen/include/asm-x86/msi.h
> @@ -3,6 +3,7 @@
>  
>  #include <xen/cpumask.h>
>  #include <xen/pci.h>
> +#include <asm/byteorder.h>
>  
>  /*
>   * Constants for Intel APIC based MSI messages.
> @@ -165,8 +166,6 @@ int msi_free_irq(struct msi_desc *entry)
>  #define MSI_LOGICAL_MODE  1
>  #define MSI_REDIRECTION_HINT_MODE 0
>  
> -#define __LITTLE_ENDIAN_BITFIELD 1
> -
>  struct msg_data {
>  #if defined(__LITTLE_ENDIAN_BITFIELD)
> __u32 vector  :  8;
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel